Add code for computing optional sequence diffs #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2865 +/- ##
==========================================
+ Coverage 67.48% 67.51% +0.02%
==========================================
Files 325 327 +2
Lines 41633 41743 +110
==========================================
+ Hits 28097 28181 +84
- Misses 11957 11978 +21
- Partials 1579 1584 +5 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Jan 24, 2025
| ys []T | ||
| } | ||
|
|
||
| func (d *differ[T]) difflen() *matrix { |
There was a problem hiding this comment.
What does difflen stand for? I assumed this was "diff length" at first look.
There was a problem hiding this comment.
I think that's right. It may be better termed edit distance or cost matrix.
|
This PR has been shipped in release v3.102.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originating from t0yv0/godifft - this may be useful for computing list diffs for display. Compared to the https://github.com/t0yv0/godifft version adds rapid tests and a function to apply the edit sequence.
Note that memory is still O(N^2) for large strings, and the naive matrix implementation may allocate a lot of memory. This is intended for comparing fairly short strings <1000 in length.