Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement shim.InstanceDiff for v2InstanceDiff2 #2869

Draft
wants to merge 1 commit into
base: vvm/remove_prc_dispatch_provider
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.37%. Comparing base (15578b7) to head (70237a9).

Files with missing lines Patch % Lines
pkg/tfshim/sdk-v2/provider2.go 82.14% 5 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           vvm/remove_prc_dispatch_provider    #2869      +/-   ##
====================================================================
- Coverage                             67.39%   67.37%   -0.03%     
====================================================================
  Files                                   327      327              
  Lines                                 41833    41844      +11     
====================================================================
- Hits                                  28193    28191       -2     
- Misses                                12053    12066      +13     
  Partials                               1587     1587              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_prc_dispatch_provider branch from 63db310 to 3821588 Compare January 27, 2025 15:47
@VenelinMartinov VenelinMartinov force-pushed the vvm/instance_diff2_shim_diff branch from 6582873 to a347dd8 Compare January 27, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant