Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation note to provider landing page for recently deprecated providers" #2883

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Feb 3, 2025

This pull request adds a list of deprecated providers to the landing page docsgen so that the page can display a deprecation warning with relevant links.

Currently, the list only contains pulumi-civo; we will add to it as we deprecate.

Part of pulumi/pulumi-civo#696.

Screenshot of expected landing page as soon as we add Civo to the list of dynamically bridged providers:

Screenshot 2025-02-03 at 1 58 31 PM
  • Add deprecation note to installation instructions and add Civo to a hardcoded list of recently-deprecated
  • Add test to show that a provider returned by getDeprecateProviderNames contains a deprecation note

@guineveresaenger guineveresaenger marked this pull request as ready for review February 3, 2025 22:20
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.74%. Comparing base (3e16a80) to head (ae3dee6).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2883      +/-   ##
==========================================
+ Coverage   67.73%   67.74%   +0.01%     
==========================================
  Files         328      328              
  Lines       42116    42132      +16     
==========================================
+ Hits        28526    28542      +16     
  Misses      11999    11999              
  Partials     1591     1591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guineveresaenger guineveresaenger requested review from mjeffryes and a team February 3, 2025 22:40
@guineveresaenger guineveresaenger merged commit 908e7f7 into master Feb 4, 2025
71 checks passed
@guineveresaenger guineveresaenger deleted the guin/add-deprecation-note branch February 4, 2025 22:11
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.103.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants