Fix the language plugin to return a version #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes `pulumi about` to show the real version instead of `unknown` for the yaml language plugin. The fix updates `GetPluginInfo` to return the `Version` from the right `version` Go package—the one that's actually being set during build via `ldflags` (`"github.com/pulumi/pulumi-yaml/pkg/version"` instead of `"github.com/pulumi/pulumi/sdk/v3/go/common/version"`, which looks to be a hold over from when this code lived in the pulumi/pulumi repo).
justinvp
force-pushed
the
justin/langhost_version
branch
from
b483edf to
78ebb54
Compare
Frassle
approved these changes
Nov 15, 2024
|
The new test I added is failing because we're not setting the version when building via the Line 63 in 3e70006 Will fix. |
justinvp
added a commit
to pulumi/pulumi-java
that referenced
this pull request
Dec 7, 2024
This change fixes `pulumi about` to show the real version instead of `unknown` for the java language plugin. The fix updates `GetPluginInfo` to return the `Version` from the right `version` Go package—the one that's actually being set during build via `ldflags` (`"github.com/pulumi/pulumi-java/pkg/version"` instead of `"github.com/pulumi/pulumi/sdk/v3/go/common/version"`). Similar to pulumi/pulumi-yaml#682 Fixes #1461
Merged
julienp
added a commit
that referenced
this pull request
Dec 17, 2024
## v1.13.0 - 2024-12-17 ### Improvements - [runtime] Allow specifying dependencies for output invokes [#693](#693) - [runtime] Update to pulumi v3.143.0 [#700](#700) ### Bug Fixes - [runtime] Fix the language plugin to return a version [#682](#682) - [runtime] Fix a mixup between package names and plugin names when listing required plugins [#688](#688) - [runtime] Resource properties marked as secret in schema are now sent as secrets [#698](#698) - [convert] Emit invoke options to PCL when ejecting YAML templates [#697](#697)
|
This PR has been shipped in release v1.13.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes
pulumi aboutto show the real version instead ofunknownfor the yaml language plugin.The fix updates
GetPluginInfoto return theVersionfrom the rightversionGo package—the one that's actually being set during build vialdflags("github.com/pulumi/pulumi-yaml/pkg/version"instead of"github.com/pulumi/pulumi/sdk/v3/go/common/version").Fixes #680