fix: gracefully proceed if favorites are not available for a player

punxaphil · Dec 29, 2023 · 9214c4f · 9214c4f
1 parent 0891712
commit 9214c4f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/src/sections/media-browser.ts b/src/sections/media-browser.ts
@@ -77,10 +77,9 @@ export class MediaBrowser extends LitElement {
       ...(this.config.customSources?.all?.map(MediaBrowser.createSource) || []),
       ...allFavorites,
     ];
-    allFavorites = this.config.numberOfFavoritesToShow
+    return this.config.numberOfFavoritesToShow
       ? allFavorites.slice(0, this.config.numberOfFavoritesToShow)
       : allFavorites;
-    return allFavorites;
   }
 
   private sortOnTopFavoritesThenAlphabetically(a: string, b: string) {

diff --git a/src/services/media-browse-service.ts b/src/services/media-browse-service.ts
@@ -28,12 +28,17 @@ export default class MediaBrowseService {
   }
 
   private async getFavoritesForPlayer(player: MediaPlayer) {
-    const favoritesRoot = await this.hassService.browseMedia(player, 'favorites', '');
-    const favoriteTypesPromise = favoritesRoot.children?.map((favoriteItem) =>
-      this.hassService.browseMedia(player, favoriteItem.media_content_type, favoriteItem.media_content_id),
-    );
-    const favoriteTypes = favoriteTypesPromise ? await Promise.all(favoriteTypesPromise) : [];
-    return favoriteTypes.flatMap((item) => item.children ?? []);
+    try {
+      const favoritesRoot = await this.hassService.browseMedia(player, 'favorites', '');
+      const favoriteTypesPromise = favoritesRoot.children?.map((favoriteItem) =>
+        this.hassService.browseMedia(player, favoriteItem.media_content_type, favoriteItem.media_content_id),
+      );
+      const favoriteTypes = favoriteTypesPromise ? await Promise.all(favoriteTypesPromise) : [];
+      return favoriteTypes.flatMap((item) => item.children ?? []);
+    } catch (e) {
+      console.log('Custom Sonos Card: error getting favorites for player ' + player.id + ': ' + JSON.stringify(e));
+      return [];
+    }
   }
 
   private getFavoritesFromStates(mediaPlayers: MediaPlayer[]) {