fix: excludeItemsInEntitiesList should default to false

punxaphil · Jan 4, 2024 · f8eb88a · f8eb88a
1 parent e515efb
commit f8eb88a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/components/player-controls.ts b/src/components/player-controls.ts
@@ -21,7 +21,7 @@ class PlayerControls extends LitElement {
     this.activePlayer = this.store.activePlayer;
     this.mediaControlService = this.store.mediaControlService;
 
-    const noUpDown = this.config.showVolumeUpAndDownButtons && nothing;
+    const noUpDown = !!this.config.showVolumeUpAndDownButtons && nothing;
     return html`
       <div class="main" id="mediaControls">
         ${when(

diff --git a/src/model/store.ts b/src/model/store.ts
@@ -114,7 +114,7 @@ export default class Store {
       .filter(getGroupPlayerIds)
       .filter((hassEntity) => {
         const includesEntity = configEntities.includes(hassEntity.entity_id);
-        return !configEntities.length || this.config.excludeItemsInEntitiesList !== includesEntity;
+        return !configEntities.length || !!this.config.excludeItemsInEntitiesList !== includesEntity;
       })
       .sort((a, b) => a.entity_id.localeCompare(b.entity_id));
   }

diff --git a/src/sections/volumes.ts b/src/sections/volumes.ts
@@ -41,7 +41,7 @@ class Volumes extends LitElement {
       : player.name;
     const volDown = async () => await this.mediaControlService.volumeDown(player, updateMembers);
     const volUp = async () => await this.mediaControlService.volumeUp(player, updateMembers);
-    const noUpDown = this.config.showVolumeUpAndDownButtons && nothing;
+    const noUpDown = !!this.config.showVolumeUpAndDownButtons && nothing;
     const hideSwitches = updateMembers || !this.showSwitches[player.id];
     return html` <div class="row">
       <div class="volume-name">

diff --git a/src/types.ts b/src/types.ts
@@ -20,9 +20,9 @@ export type ConfigPredefinedGroupPlayer = PredefinedGroupPlayer<string>;
 export type ConfigPredefinedGroup = PredefinedGroup<string | ConfigPredefinedGroupPlayer>;
 export interface CardConfig extends LovelaceCardConfig {
   sections?: Section[];
-  showVolumeUpAndDownButtons: boolean;
+  showVolumeUpAndDownButtons?: boolean;
   entities?: string[];
-  excludeItemsInEntitiesList: boolean;
+  excludeItemsInEntitiesList?: boolean;
   predefinedGroups?: ConfigPredefinedGroup[];
   title?: string;
   labelWhenNoMediaIsSelected?: string;
@@ -32,14 +32,14 @@ export interface CardConfig extends LovelaceCardConfig {
   artworkHostname?: string;
   widthPercentage?: number;
   heightPercentage?: number;
-  hideGroupCurrentTrack: boolean;
-  dynamicVolumeSlider: boolean;
+  hideGroupCurrentTrack?: boolean;
+  dynamicVolumeSlider?: boolean;
   mediaArtworkOverrides?: MediaArtworkOverride[];
   customSources?: CustomSources;
   customThumbnail?: CustomThumbnails;
   customThumbnailIfMissing?: CustomThumbnails;
   mediaBrowserTitlesToIgnore?: string[];
-  mediaBrowserItemsPerRow: number;
+  mediaBrowserItemsPerRow?: number;
   mediaBrowserShowTitleForThumbnailIcons?: boolean;
   topFavorites?: string[];
   numberOfFavoritesToShow?: number;