Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep v3.4.0 #1420

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Release prep v3.4.0 #1420

merged 3 commits into from
Nov 29, 2024

Conversation

github-actions[bot]
Copy link

Automated release-prep from commit 594f971.

@github-actions github-actions bot requested a review from a team as a code owner November 25, 2024 10:32
@github-actions github-actions bot added the maintenance Internal maintenance work that shouldn't appear in the changelog label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (594f971) to head (8195705).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files         127      127           
  Lines        5317     5317           
=======================================
  Hits         4705     4705           
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also contains corrections to `CHANGELOG.md` and a minor typo fix in the last release within `release_notes_pdk.md`.
@david22swan david22swan changed the title Release prep v3.4.0 (NO_MERGE)Release prep v3.4.0 Nov 25, 2024
@david22swan david22swan changed the title (NO_MERGE)Release prep v3.4.0 Release prep v3.4.0 Nov 29, 2024
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@gavindidrichsen gavindidrichsen merged commit 57abb54 into main Nov 29, 2024
11 checks passed
@gavindidrichsen gavindidrichsen deleted the release-prep branch November 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants