support multiple puppetdb servers #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really own this per-say, nor have I tested it. The original PR was abandoned, and I was unable to rebase as the author's repo was migrated into another org. |
|
Seems to address #386 but needs to be finished. Original author is no longer working on it if someone else is interested in picking this up. |
bastelfreak
reviewed
May 8, 2024
| @@ -6,7 +6,7 @@ | |||
| $database_username = $puppetdb::params::database_username, | |||
| $read_database_username = $puppetdb::params::read_database_username, | |||
| $read_database_host = $puppetdb::params::read_database_host, | |||
| $puppetdb_server = $puppetdb::params::puppetdb_server, | |||
| Variant[String,Array[String, 1]] $puppetdb_server = $puppetdb::params::puppetdb_server, | |||
There was a problem hiding this comment.
I think that's the least we should do. would even be better to enforce IP/FQDN, but I don't know out of my head what kind of values are allowed here.
Suggested change
| Variant[String,Array[String, 1]] $puppetdb_server = $puppetdb::params::puppetdb_server, | |
| Variant[String[1],Array[String[1], 1]] $puppetdb_server = $puppetdb::params::puppetdb_server, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrated from PR #351 originally submitted by @bassonj
per documentation at https://puppet.com/docs/puppetdb/7/puppetdb_connection.html#server_urls