Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This line is not necessary, and it is causing puppetdb to crash. #203

Closed

Conversation

felipeatsix
Copy link
Contributor

@felipeatsix felipeatsix commented Jan 24, 2024

As discussed on #202 I'm opening this PR with this simple fix.

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ felipeatsix
❌ f.santos


f.santos seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Xtigyro
Copy link
Contributor

Xtigyro commented Jan 24, 2024

@felipeatsix Thanks for your contribution!

You'd need to sign the CLA. Could you please do so?

@Xtigyro
Copy link
Contributor

Xtigyro commented Jan 30, 2024

@felipeatsix Could you please sign the CLA?

I'm just committing again to fix the dummy account issue
@felipeatsix
Copy link
Contributor Author

Hi @Xtigyro sorry for the delay, I just noticed that my first commit was submitted using my company username, which it does not have a github account, now I have submitted another commit with my correct username and we can see the CLA assistant is complaining about only 1 out of 2 committers have signed it.

What is the recommended solution in this case?

@Xtigyro
Copy link
Contributor

Xtigyro commented Jan 30, 2024

@felipeatsix The CLA is still not signed. It should be here: https://cla-assistant.io/puppetlabs/puppetserver-helm-chart?pullRequest=203

Also - could you please update the CHANGELOG and bump the minor (second digit) chart version in Chart.yaml?

@felipeatsix
Copy link
Contributor Author

felipeatsix commented Jan 31, 2024

@Xtigyro The CLA is signed by my personal github account, which is the only one I can use to sign it, however, the problem here is that I sent the first commit using my company git user, which it does not have a github user account related to it, and I can't sign the CLA for that account because it is unexisting in github.

Hence, I prepared a new PR using only my personal account, where I also provided the required changelog updates.

#204

@felipeatsix felipeatsix deleted the felipeatsix_issue_202 branch February 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants