Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'netrc' credentials to documentation #211

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

cpiment
Copy link
Contributor

@cpiment cpiment commented Mar 27, 2024

I was trying to use a control repo cloned by HTTPS instead of SSH, and detected that in the templates existed a r10k.code.viaHttps.credentials setting that was not referenced in the documentation. This PR tries to fix that.

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

@ldaneliukas
Copy link
Collaborator

Thanks for the fix @cpiment! Could you possibly add info on using existingSecret for viaHttps so it matches viaSsh?

@cpiment
Copy link
Contributor Author

cpiment commented Mar 27, 2024

Thanks for your comments @ldaneliukas. I have made the suggested changes to README.md

@Xtigyro
Copy link
Contributor

Xtigyro commented Mar 27, 2024

@cpiment Could you please also bump the bugfix version of the chart in Chart.yaml and update the CHANGELOG.md?

@cpiment
Copy link
Contributor Author

cpiment commented Mar 27, 2024

Hi @Xtigyro, I made the requested changes. Thanks!

@ldaneliukas
Copy link
Collaborator

Great! One last thing, the unit test snapshots include the chart version, could you update them with helm unittest . -u. ?

@cpiment
Copy link
Contributor Author

cpiment commented Mar 27, 2024

Hi @ldaneliukas, I have updated the unit test snapshots as requested. Thanks!

@ldaneliukas ldaneliukas merged commit 41fd600 into puppetlabs:master Mar 28, 2024
3 checks passed
@cpiment cpiment deleted the netrc-docs branch March 28, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants