bug fix: let eyaml secret to be mounted, even when hiera config is no… #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashish1099
requested review from
Xtigyro,
davidphay and
ldaneliukas
as code owners
ashish1099
changed the title
|
Nice PR thanks ! Can you please bump the minor version and update the Changelog? Finally, you might want to include your name in the Credits? |
|
Have added my name in the credits |
…am change in docker build for puppetserver [here](voxpupuli/container-puppetserver#87) due to set -e, the set-permission ends up with exit status 1 ```raw puppetserver-puppet8 Running /docker-entrypoint.d/20-use-templates-initially.sh puppetserver-puppet8 Upgrading /opt/puppetlabs/server/data/puppetserver/vendored-jruby-gems puppetserver-puppet8 Running /docker-entrypoint.d/30-set-permissions.sh puppetserver-puppet8 chown: changing ownership of /etc/puppetlabs/puppet/eyaml/keys/private_key.pkcs7.pem: Read-only file system puppetserver-puppet8 chown: changing ownership of /etc/puppetlabs/puppet/eyaml/keys/public_key.pkcs7.pem: Read-only file system puppetserver-puppet8 chown: changing ownership of /etc/puppetlabs/puppet/eyaml/keys/..data: Read-only file system puppetserver-puppet8 chown: changing ownership of /etc/puppetlabs/puppet/eyaml/keys/..2024_12_31_07_02_41.3099963006/private_key.pkcs7.pem: Read-only file system puppetserver-puppet8 chown: changing ownership of /etc/puppetlabs/puppet/eyaml/keys/..2024_12_31_07_02_41.3099963006/public_key.pkcs7.pem: Read-only file system puppetserver-puppet8 chown: changing ownership of /etc/puppetlabs/puppet/eyaml/keys/..2024_12_31_07_02_41.3099963006: Read-only file system puppetserver-puppet8 chown: changing ownership of /etc/puppetlabs/puppet/eyaml/keys: Read-only file system ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t given