Skip to content

Commit

Permalink
Fix W4902
Browse files Browse the repository at this point in the history
  • Loading branch information
mayankpatibandla committed Mar 5, 2024
1 parent 1c4c1da commit cd8bb4a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
# W0212: Access to a protected member
# W0101: Unreachable code
# E0110: Instantiated abstract class
# W4902: Using deprecated method

# Performance optimization
# W1203: Use % formatting in logging functions and pass the parameters as arguments
Expand Down Expand Up @@ -67,4 +66,4 @@ disable = C0114, C0115, C0116, R0903, C0415, R0913, W1203, R1729, E1120, E1123
R0912, R0911, W0511, R0902, C0412, C0103, C0301, R1732, R0915, W1514,
E1101, R1734, W1201,
E0401, W0212, R0904, W0101,
C0302, E0110, W0603, R0401, W4902
C0302, E0110, W0603, R0401
4 changes: 2 additions & 2 deletions pros/conductor/project/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def make(self, build_args: List[str]):
stdout=stdout_pipe, stderr=stderr_pipe)
except Exception as e:
if not os.environ.get('PROS_TOOLCHAIN'):
ui.logger(__name__).warn("PROS toolchain not found! Please ensure the toolchain is installed correctly and your environment variables are set properly.\n")
ui.logger(__name__).warning("PROS toolchain not found! Please ensure the toolchain is installed correctly and your environment variables are set properly.\n")
ui.logger(__name__).error(f"ERROR WHILE CALLING '{make_cmd}' WITH EXCEPTION: {str(e)}\n",extra={'sentry':False})
stdout_pipe.close()
stderr_pipe.close()
Expand Down Expand Up @@ -292,7 +292,7 @@ def libscanbuild_capture(args: argparse.Namespace) -> Tuple[int, Iterable[Compil
exit_code = run_build(args.build, env=environment, stdout=pipe, stderr=pipe, cwd=self.directory)
except Exception as e:
if not os.environ.get('PROS_TOOLCHAIN'):
ui.logger(__name__).warn("PROS toolchain not found! Please ensure the toolchain is installed correctly and your environment variables are set properly.\n")
ui.logger(__name__).warning("PROS toolchain not found! Please ensure the toolchain is installed correctly and your environment variables are set properly.\n")
ui.logger(__name__).error(f"ERROR WHILE CALLING '{make_cmd}' WITH EXCEPTION: {str(e)}\n",extra={'sentry':False})
if not suppress_output:
pipe.close()
Expand Down

0 comments on commit cd8bb4a

Please sign in to comment.