🔖 Release 3.5.2 #353
Merged
🔖 Release 3.5.2 #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ayushuk
commented
May 18, 2024
ayushuk
commented
- 🧹Remove Okapilib as a default template for PROS 4 #351
- 🧹 Remove PROS 4 Prompts #346
- 🚸 Apply liblvgl when upgrading to PROS 4 #345
* Apply liblvgl when upgrading from PROS 3 to PROS 4 * Fetch template if necessary
* Update version numbers * 🐛 Fix default template selection #318 * Update version numbers * Update version numbers --------- Co-authored-by: BennyBot <[email protected]>
noam987
reviewed
May 18, 2024
| @@ -159,7 +159,7 @@ def upgrade(ctx: click.Context, project: c.Project, query: c.BaseTemplate, **kwa | |||
| """ | |||
| analytics.send("upgrade-project") | |||
| if not query.name: | |||
| for template in project.templates.keys(): | |||
| for template in tuple(project.templates.keys()): | |||
There was a problem hiding this comment.
Just to be sure, this won't break if they have old conductor files?
There was a problem hiding this comment.
From my understanding, this function doesn't touch the conductor file (there are no .save() calls).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.