Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix Error Reading project.pros File with Certain Chinese Characters on Windows #377

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

gajarhalwa14
Copy link
Contributor

Summary:

Fixes a bug where the project.pros file couldn't be read with certain Chinese characters on Windows devices

Motivation:

Fixes the Chinese character issue

References (optional):

Closes #376

Test Plan:

  • Create a new PROS project with the latest version
  • Open the project.pros file
  • Replace the kernel's location with "C:\\Users\\杨\\AppData\\Roaming\\PROS\\templates\\[email protected]"
  • run pros c info-project

Copy link
Member

@mayankpatibandla mayankpatibandla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayankpatibandla mayankpatibandla merged commit fb9e846 into develop Sep 26, 2024
10 checks passed
@mayankpatibandla mayankpatibandla deleted the chinese-char-bug-fix branch September 26, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛Error reading project.pros file with some Chinese characters on Windows
2 participants