Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added the designed pages in app.js #128

Closed

Conversation

ShambhaviSharma0110
Copy link

Related Issuse

  • Info about Issue or bug

Closes: #113

Describe the changes you've made

Already the navbar and homepage were made but weren't imported in the app.js or exported from their respective files

Checklist:

  • [ x] My code follows the style guidelines of this project.
  • [ x] I have performed a self-review of my own code.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • [ x] My changes generate no new warnings.

Screenshots

Original Updated
original screenshot updated screenshot
image

@codewithvk
Copy link
Collaborator

@ShambhaviSharma0110 Resolve conflict.

@ShambhaviSharma0110
Copy link
Author

on it!

@ShambhaviSharma0110
Copy link
Author

hey it seems to be running fine for me with my code please check

@codewithvk
Copy link
Collaborator

@ShambhaviSharma0110 first fetch data from the repository after You should check.

@purnima143 purnima143 closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding about section and contribution details etc in homepage
3 participants