Skip to content

Commit

Permalink
Merge branch 'r2.2.3'
Browse files Browse the repository at this point in the history
  • Loading branch information
pl committed Sep 10, 2014
2 parents b679853 + 461879f commit 95d1130
Show file tree
Hide file tree
Showing 18 changed files with 64 additions and 39 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.markdown
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## 2.2.3 (2014-09-10)

[FIXED] Wrong encoding of HTTP heartbeats

[FIXED] Missing httpPath parameter for sockjs transport

[FIXED] Auth query strings no longer start with `&`

## 2.2.2 (2014-06-09)

[CHANGED] Updated the HTTPS CDN URL to `https://js.pusher.com`
Expand Down
2 changes: 1 addition & 1 deletion JFile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ target_dir './dist'

src_dir './src'

version '2.2.2'
version '2.2.3'

bundle 'pusher.js' do
license 'pusher-licence.js'
Expand Down
2 changes: 1 addition & 1 deletion dist/flashfallback.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Pusher JavaScript Library v2.2.2
* Pusher JavaScript Library v2.2.3
* http://pusherapp.com/
*
* Copyright 2011, Pusher
Expand Down
2 changes: 1 addition & 1 deletion dist/flashfallback.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions dist/pusher.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Pusher JavaScript Library v2.2.2
* Pusher JavaScript Library v2.2.3
* http://pusher.com/
*
* Copyright 2014, Pusher
Expand Down Expand Up @@ -626,7 +626,7 @@
}).call(this);

;(function() {
Pusher.VERSION = '2.2.2';
Pusher.VERSION = '2.2.3';
Pusher.PROTOCOL = 7;

// DEPRECATED: WS connection parameters
Expand Down Expand Up @@ -678,7 +678,8 @@
}]],
[":def", "sockjs_options", {
hostUnencrypted: config.httpHost + ":" + config.httpPort,
hostEncrypted: config.httpHost + ":" + config.httpsPort
hostEncrypted: config.httpHost + ":" + config.httpsPort,
httpPath: config.httpPath
}],
[":def", "timeouts", {
loop: true,
Expand Down Expand Up @@ -3918,7 +3919,7 @@

Pusher.Channel.Authorizer.prototype = {
composeQuery: function(socketId) {
var query = '&socket_id=' + encodeURIComponent(socketId) +
var query = 'socket_id=' + encodeURIComponent(socketId) +
'&channel_name=' + encodeURIComponent(this.channel.name);

for(var i in this.authOptions.params) {
Expand Down Expand Up @@ -3999,6 +4000,7 @@
script.src = this.options.authEndpoint +
'?callback=' +
encodeURIComponent(callback_name) +
'&' +
this.composeQuery(socketId);

var head = document.getElementsByTagName("head")[0] || document.documentElement;
Expand Down
18 changes: 9 additions & 9 deletions dist/pusher.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions dist/xdr.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Pusher JavaScript Library v2.2.2
* Pusher JavaScript Library v2.2.3
* http://pusher.com/
*
* Copyright 2014, Pusher
Expand Down Expand Up @@ -346,7 +346,7 @@
socket.sendRaw("[]");
},
sendHeartbeat: function(socket) {
socket.sendRaw("h");
socket.sendRaw("[]");
},
onFinished: function(socket, status) {
socket.onClose(1006, "Connection interrupted (" + status + ")", false);
Expand All @@ -367,7 +367,7 @@
// next HTTP request will reset server's activity timer
},
sendHeartbeat: function(socket) {
socket.sendRaw("h");
socket.sendRaw("[]");
},
onFinished: function(socket, status) {
if (status === 200) {
Expand Down
6 changes: 3 additions & 3 deletions dist/xdr.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions dist/xhr.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Pusher JavaScript Library v2.2.2
* Pusher JavaScript Library v2.2.3
* http://pusher.com/
*
* Copyright 2014, Pusher
Expand Down Expand Up @@ -343,7 +343,7 @@
socket.sendRaw("[]");
},
sendHeartbeat: function(socket) {
socket.sendRaw("h");
socket.sendRaw("[]");
},
onFinished: function(socket, status) {
socket.onClose(1006, "Connection interrupted (" + status + ")", false);
Expand All @@ -364,7 +364,7 @@
// next HTTP request will reset server's activity timer
},
sendHeartbeat: function(socket) {
socket.sendRaw("h");
socket.sendRaw("[]");
},
onFinished: function(socket, status) {
if (status === 200) {
Expand Down
Loading

0 comments on commit 95d1130

Please sign in to comment.