Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

feat: add skus, checkout.session and data reset functionality #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

omairvaiyani
Copy link

Pending tests, once I figure out how it's done.

Adds these endpoints

  • skus.create
  • skus.retrieve
  • skus.list
  • checkout.session.create
  • checkout.session.retrieve

Adds a resetData export to support beforeEach / afterEach pattern.

@pushplay
Copy link
Owner

Just wanted to let you know I haven't forgotten about this. I'm going to review it tonight or tomorrow morning.

@pushplay
Copy link
Owner

The sku and checkout session work all looks great.

What's the use case for deleting one account's data and not all data from all accounts? My concern is that it would be easy to create an inconsistent state when I think the default assumption would be that calling resetData() applies to all accounts.

@pushplay pushplay added the enhancement New feature or request label Dec 18, 2020
@omairvaiyani
Copy link
Author

@pushplay that's a fair point, I think deleting all account data makes more sense too - we didn't have a use-case for it, since we only use the default account

@pushplay
Copy link
Owner

pushplay commented Jan 3, 2021

So this has gotten a bit stale. Do you want to make changes to apply resetData() to all accounts? Alternately I can merge it and then do a bit of reworking myself.

@cbarratt
Copy link

cbarratt commented Nov 7, 2022

Would be great to get this in if I can help contribute

@pushplay
Copy link
Owner

pushplay commented Nov 8, 2022

Hi. This project hasn't been updated in a long time. I don't know if it's still useful to people. It's not useful to me.

If you want to fork the project I'll support that. If you submit a PR that looks reasonable I can merge and do a release.

Cheers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants