Update module github.com/argoproj/argo-cd/v2 to v2.7.16 [SECURITY] #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2.7.14
->v2.7.16
GitHub Vulnerability Alerts
CVE-2024-22424
Impact
The Argo CD API prior to versions 2.10-rc2, 2.9.4, 2.8.8, and 2.7.16 are vulnerable to a cross-server request forgery (CSRF) attack when the attacker has the ability to write HTML to a page on the same parent domain as Argo CD.
A CSRF attack works by tricking an authenticated Argo CD user into loading a web page which contains code to call Argo CD API endpoints on the victim’s behalf. For example, an attacker could send an Argo CD user a link to a page which looks harmless but in the background calls an Argo CD API endpoint to create an application running malicious code.
Argo CD uses the “Lax” SameSite cookie policy to prevent CSRF attacks where the attacker controls an external domain. The malicious external website can attempt to call the Argo CD API, but the web browser will refuse to send the Argo CD auth token with the request.
Many companies host Argo CD on an internal subdomain, such as https://argo-cd.internal.example.com. If an attacker can place malicious code on, for example, https://test.internal.example.com/, they can still perform a CSRF attack. In this case, the “Lax” SameSite cookie does not prevent the browser from sending the auth cookie, because the destination is a parent domain of the Argo CD API.
Browsers generally block such attacks by applying CORS policies to sensitive requests with sensitive content types. Specifically, browsers will send a “preflight request” for POSTs with content type “application/json” asking the destination API “are you allowed to accept requests from my domain?” If the destination API does not answer “yes,” the browser will block the request.
Before the patched versions, Argo CD did not validate that requests contained the correct content type header. So an attacker could bypass the browser’s CORS check by setting the content type to something which is considered “not sensitive” such as “text/plain.” The browser wouldn’t send the preflight request, and Argo CD would happily accept the contents (which are actually still JSON) and perform the requested action (such as running malicious code).
Patches
A patch for this vulnerability has been released in the following Argo CD versions:
🚨 The patch contains a breaking API change. 🚨 The Argo CD API will no longer accept non-GET requests which do not specify application/json as their Content-Type. The accepted content types list is configurable, and it is possible (but discouraged) to disable the content type check completely.
Workarounds
The only way to completely resolve the issue is to upgrade.
Credits
The Argo CD team would like to express their gratitude to An Trinh of Calif who reported the issue confidentially according to our guidelines and published a helpful blog post to describe the issue. We would also like to thank them for actively participating in the review for the patch.
References
Release Notes
argoproj/argo-cd (github.com/argoproj/argo-cd/v2)
v2.7.16
Compare Source
Quick Start
Non-HA:
HA:
Release Signatures and Provenance
All Argo CD container images are signed by cosign. A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the documentation on how to verify.
Upgrading
If upgrading from a different minor version, be sure to read the upgrading documentation.
Changelog
This release fixes a security issue: GHSA-92mw-q256-5vwg
🚨 Important: The security fix includes a breaking API change. Please read the GHSA before upgrading! 🚨
Bug fixes
1b69ce6
: fix(grpcproxy): add GRPCKeepAliveEnforcementMinimum (#16567) (@todaywasawesome)460c4cd
: fix(ui): set content-type for certain UI requests (#16923) (#16930) (#16935) (@gcp-cherry-pick-bot[bot])13fe3ca
: fix: enforce content type header for API requests (#16860) (Cherry-pick release-2.7) (#16880) (@alexmt)Documentation
c3f55ea
: docs: Fix format issue in rbac.md (#16521) (#16540) (@gcp-cherry-pick-bot[bot])Dependency updates
fa0c504
: chore(deps): bump github.com/go-git/go-git/v5 from 5.6.1 to 5.11.0 (#16914) (@crenshaw-dev)Full Changelog: argoproj/argo-cd@v2.7.15...v2.7.16
v2.7.15
Compare Source
Quick Start
Non-HA:
HA:
Release Signatures and Provenance
All Argo CD container images are signed by cosign. A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the documentation on how to verify.
Upgrading
If upgrading from a different minor version, be sure to read the upgrading documentation.
Changelog
Bug fixes
1199f59
: fix(appset): performProgressiveSyncs only when the applicationset is using it (#15299) (#15992) (@gcp-cherry-pick-bot[bot])e74c6ca
: fix(notifications): Allow notifications controller to notify on all namespaces (cherry-pick 2.7) (#15856) (@crenshaw-dev)733bcab
: fix(server): not need send application if it is not under enabled namespaces (#14479) (#15474) (@jannfis)257be07
: fix: Allow retrieving badges in other namespaces (#15468) (#15483) (@jannfis)8da0d9e
: fix: Updated docs about using a slash in ignoreDifferences (#15144) (#15169) (@gcp-cherry-pick-bot[bot])6ab8512
: fix: argocd notification controller app cluster permission issue (#16057) (#16161) (@gcp-cherry-pick-bot[bot])67734db
: fix: handle annotations for resources with ':' in the name (#15101) (#15380) (#15413) (@gcp-cherry-pick-bot[bot])0b4d410
: fix: helm set parameter to allow passing list parameters (#15978) (#15995) (@gcp-cherry-pick-bot[bot])3cc00d2
: fix: make WatchResourceTree use namespaced cache key (#15258) (#15523) (@gcp-cherry-pick-bot[bot])Documentation
5d14411
: docs(cmp): fix CMP param getter example (#16077) (#16190) (#16199) (@gcp-cherry-pick-bot[bot])86b3827
: docs: 'action' RBAC example for Kind without group (#15589) (#15598) (@gcp-cherry-pick-bot[bot])51b1d50
: docs: Fix docs for destinations in AppProjects (#15153) (#15182) (#15539) (@gcp-cherry-pick-bot[bot])Dependency updates
66a8905
: chore(deps): bump cosign-installer from 3.0.1 to 3.2.0 (#16537) (@crenshaw-dev)007dc54
: chore(deps): upgrade Go version to 1.20 (#16100) (@iam-veeramalla)Other work
5e71872
: chore: Upgrade Redis to redis:7.0.14 (#16164) (#16221) (@shyukri)485731d
: fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065) (#15559) (@gcp-cherry-pick-bot[bot])0ef9f09
: fix(repo-server): avoid fetching commit sha for multisource applications (#15037) (#15067) (#15556) (@gcp-cherry-pick-bot[bot])Full Changelog: argoproj/argo-cd@v2.7.14...v2.7.15
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.