change all to use === instead of ==

puzzle · Dec 17, 2024 · 114b64c · 114b64c
1 parent 16b6437
commit 114b64c
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 33 deletions.
diff --git a/frontend/eslint.config.mjs b/frontend/eslint.config.mjs
@@ -4,7 +4,6 @@ import unusedImports from 'eslint-plugin-unused-imports'
 import stylistic from '@stylistic/eslint-plugin'
 import html from '@html-eslint/eslint-plugin'
 import angular from 'angular-eslint'
-import htmlParser from '@html-eslint/parser'
 
 export default tsEslint.config(
   {
@@ -76,12 +75,10 @@ export default tsEslint.config(
         },
       ],
       'prefer-rest-params': 'error',
-      '@typescript-eslint/no-empty-function': ['error', { allow: ['arrowFunctions', 'constructors'] }],
+      '@typescript-eslint/no-empty-function': ['error', {allow: ['arrowFunctions', 'constructors']}],
       '@stylistic/lines-around-comment': ['error'],
       '@angular-eslint/no-empty-lifecycle-method': 'error',
       '@angular-eslint/component-class-suffix': 'error',
-      '@angular-eslint/template/eqeqeq': 'off',
-      '@angular-eslint/template/interactive-supports-focus': 'off',
       '@typescript-eslint/no-non-null-asserted-optional-chain': 'off',
       '@typescript-eslint/no-non-null-assertion': 'off',
       '@stylistic/no-extra-parens': 'off',
@@ -95,15 +92,15 @@ export default tsEslint.config(
       // '@stylistic/quotes': ['error', 'double'],
       '@stylistic/padded-blocks': ['error', 'never'],
       '@stylistic/dot-location': ['error', 'property'],
-      '@stylistic/newline-per-chained-call': ['error', { ignoreChainWithDepth: 1 }],
+      '@stylistic/newline-per-chained-call': ['error', {ignoreChainWithDepth: 1}],
       '@stylistic/indent': ['error', 2],
       '@stylistic/quote-props': ['error', 'as-needed'],
       '@stylistic/object-property-newline': ['error'],
       '@stylistic/multiline-ternary': ['off'],
       '@stylistic/object-curly-spacing': ['error', 'always'],
-      '@stylistic/array-bracket-newline': ['error', { minItems: 4 }],
+      '@stylistic/array-bracket-newline': ['error', {minItems: 4}],
       '@stylistic/semi-style': ['error'],
-      '@stylistic/function-paren-newline': ['error', { minItems: 4 }],
+      '@stylistic/function-paren-newline': ['error', {minItems: 4}],
       '@angular-eslint/directive-selector': [
         'error',
         {
@@ -136,23 +133,20 @@ export default tsEslint.config(
 
   {
     files: ['**/*.html'],
-    // recommended configuration included in the plugin
-    ...html.configs['flat/recommended'],
-    //extends: [...angular.configs.templateRecommended, ...angular.configs.templateAccessibility],
-    //processor: angular.processInlineTemplates,
-    //languageOptions: {
-    //parser: angularTemplateParser,
-    //},
+    extends: [
+      ...angular.configs.templateRecommended,
+    ],
     languageOptions: {
-      parser: htmlParser,
+      parser: angular.templateParser,
     },
+
     rules: {
       ...html.configs['flat/recommended'].rules,
-      // Must be defined. If not, all recommended rules will be lost
+      '@angular-eslint/template/eqeqeq': 'error',
       '@html-eslint/indent': ['error', 2],
       '@html-eslint/require-img-alt': 'off',
       '@html-eslint/element-newline': 'off',
-      '@html-eslint/require-closing-tags': ['error', { selfClosing: 'always' }],
+      '@html-eslint/require-closing-tags': ['error', {selfClosing: 'always'}],
     },
   },
   {

diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/package.json b/frontend/package.json
@@ -27,6 +27,7 @@
   },
   "private": true,
   "dependencies": {
+    "@angular-eslint/eslint-plugin-template": "^19.0.2",
     "@angular/animations": "^18.2.8",
     "@angular/cdk": "^18.2.9",
     "@angular/common": "^18.2.8",

diff --git a/frontend/src/app/components/keyresult-detail/keyresult-detail.component.html b/frontend/src/app/components/keyresult-detail/keyresult-detail.component.html
@@ -52,7 +52,7 @@ <h4 class="confidence-label">Confidence</h4>
         </section>
 
         <section class="d-flex gap-4 flex-row mb-2-rem">
-          <ng-container *ngIf="keyResult.keyResultType == 'metric' && castToMetric(keyResult) as keyResultMetric">
+          <ng-container *ngIf="keyResult.keyResultType === 'metric' && castToMetric(keyResult) as keyResultMetric">
             <div class="d-flex justify-content-start w-100 metric-label-div">
               <p class="keyResult-detail-attribute-show rounded-5 p-2 d-flex justify-content-center metric-col">
                 Baseline: {{ keyResultMetric.baseline | unitTransformation: keyResultMetric.unit }}
@@ -76,7 +76,7 @@ <h4 class="confidence-label">Confidence</h4>
             </div>
           </ng-container>
 
-          <ng-container *ngIf="keyResult.keyResultType == 'ordinal' && castToOrdinal(keyResult) as keyResultOrdinal">
+          <ng-container *ngIf="keyResult.keyResultType === 'ordinal' && castToOrdinal(keyResult) as keyResultOrdinal">
             <div class="d-flex justify-content-between w-100 ordinal-div mb-4">
               <div class="ordinal-col h-auto">
                 <h4 class="mb-1">Commit</h4>
@@ -106,7 +106,7 @@ <h3 class="mb-1">Beschrieb</h3>
             <p class="linebreak">{{ keyResult.description || "-" }}</p>
           </div>
 
-          <div *ngIf="keyResult.actionList?.length != 0" class="mb-2-rem">
+          <div *ngIf="keyResult.actionList?.length !== 0" class="mb-2-rem">
             <h3>Action Plan</h3>
             <div *ngFor="let action of keyResult.actionList">
               <div *ngIf="action.isChecked">

diff --git a/frontend/src/app/components/keyresult/keyresult.component.html b/frontend/src/app/components/keyresult/keyresult.component.html
@@ -15,7 +15,7 @@ <h3 class="linebreak mb-3">{{ keyResult.title }}</h3>
     <div class="d-flex justify-content-center align-items-center flex-wrap">
       <h4 class="text-nowrap me-2">Letztes Check-in</h4>
       <span class="keyResult-attribute-show">{{
-        getKeyResultWithCorrectType().lastCheckIn == null
+        getKeyResultWithCorrectType().lastCheckIn === null
         ? "Keines"
         : (getKeyResultWithCorrectType().lastCheckIn!.createdOn | date: DATE_FORMAT)
         }}</span>

diff --git a/frontend/src/app/components/objective-detail/objective-detail.component.html b/frontend/src/app/components/objective-detail/objective-detail.component.html
@@ -28,7 +28,7 @@ <h3 class="mb-1">Beschrieb</h3>
           <p>{{ objective.description }}</p>
         </div>
 
-        <div class="d-flex align-items-center flex-row justify-content-start" *ngIf="objective.state.toUpperCase() != 'SUCCESSFUL' && objective.state.toUpperCase() != 'NOTSUCCESSFUL'">
+        <div class="d-flex align-items-center flex-row justify-content-start" *ngIf="objective.state.toUpperCase() !== 'SUCCESSFUL' && objective.state.toUpperCase() !== 'NOTSUCCESSFUL'">
           <button
             *ngIf="objective.writeable"
             mat-flat-button

diff --git a/frontend/src/app/components/overview/overview.component.html b/frontend/src/app/components/overview/overview.component.html
@@ -6,7 +6,7 @@
 >
   <app-team *ngFor="let overviewEntity of overviewEntities$ | async; trackBy: trackByFn" [overviewEntity]="overviewEntity">
   </app-team>
-  <div *ngIf="(overviewEntities$ | async)?.length == 0" class="d-flex align-items-center flex-column pt-5 gap-5">
+  <div *ngIf="(overviewEntities$ | async)?.length === 0" class="d-flex align-items-center flex-column pt-5 gap-5">
     <p id="no-team-text">Kein Team ausgewählt</p>
     <img
       src="{{ this.backgroundLogoSrc$ | async }}"

diff --git a/frontend/src/app/components/team-filter/team-filter.component.html b/frontend/src/app/components/team-filter/team-filter.component.html
@@ -2,7 +2,7 @@
   <button (click)="toggleAll()" class="icon-button focus-outline mt-1 me-1">
     <mat-chip
       [attr.data-testId]="'team-filter-alle'"
-      [highlighted]="activeTeams.length == (this.teams$ | async)?.length"
+      [highlighted]="activeTeams.length === (this.teams$ | async)?.length"
       color="primary"
     >
       <p>Alle</p>

diff --git a/frontend/src/app/shared/custom/scoring/scoring.component.html b/frontend/src/app/shared/custom/scoring/scoring.component.html
@@ -21,7 +21,7 @@ <h5 class="text-center text-small">Target</h5>
             [attr.data-testId]="'fail'"
             class="child h-100 d-flex align-items-center"
           >
-            <div *ngIf="keyResult.keyResultType == 'metric' && calculateCurrentPercentage(castToMetric()) < 1" class="fs-6 text-white fw-bold text-center score-red scoring-error-badge rounded-circle">
+            <div *ngIf="keyResult.keyResultType === 'metric' && calculateCurrentPercentage(castToMetric()) < 1" class="fs-6 text-white fw-bold text-center score-red scoring-error-badge rounded-circle">
               !
             </div>
           </span>

diff --git a/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html b/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html
@@ -14,7 +14,7 @@ <h4 class="okr-form-label okr-form-col">Objective</h4>
           <button
             class="col successful valuation-card card-hover-successful"
             [ngClass]="{
-              'active-successful': completeForm.value.isSuccessful == true,
+              'active-successful': completeForm.value.isSuccessful === true,
               'non-active-successful': completeForm.value.isSuccessful === false,
             }"
             (click)="switchSuccessState('successful')"
@@ -28,7 +28,7 @@ <h4 class="okr-form-label okr-form-col">Objective</h4>
             class="col not-successful valuation-card card-hover-not-successful"
             [ngClass]="{
               'active-not-successful': completeForm.value.isSuccessful === false,
-              'non-active-not-successful': completeForm.value.isSuccessful == true,
+              'non-active-not-successful': completeForm.value.isSuccessful === true,
             }"
             (click)="switchSuccessState('notSuccessful')"
             (keydown.enter)="switchSuccessState('notSuccessful')"

diff --git a/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html b/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html
@@ -123,7 +123,7 @@
       </button>
     </div>
 
-    <div class="col-auto" *ngIf="data.objective.objectiveId && data.action != 'duplicate'">
+    <div class="col-auto" *ngIf="data.objective.objectiveId && data.action !== 'duplicate'">
       <button
         color="primary"
         type="button"