add e2e for feature

puzzle · Jan 10, 2025 · 2264b6f · 2264b6f
1 parent 1f5bb41
commit 2264b6f
Show file tree

Hide file tree

Showing 6 changed files with 62 additions and 6 deletions.
diff --git a/frontend/cypress/e2e/check-in.cy.ts b/frontend/cypress/e2e/check-in.cy.ts
@@ -39,6 +39,43 @@ describe('okr check-in', () => {
     cy.contains('We bought a new house');
   });
 
+  it('should create check-in metric and assert correct owner', () => {
+    overviewPage
+      .addKeyResult()
+      .fillKeyResultTitle('This keyresult is for the owner')
+      .withMetricValues(Unit.PERCENT, '21', '51')
+      .fillKeyResultDescription('This is my description')
+      .submit();
+    keyResultDetailPage
+      .visit('This keyresult is for the owner')
+      .createCheckIn()
+      .checkForDialogTextMetric()
+      .fillMetricCheckInValue('30')
+      .setCheckInConfidence(6)
+      .fillCheckInCommentary('We bought a new house')
+      .fillCheckInInitiatives('We have to buy more PCs')
+      .submit();
+
+    keyResultDetailPage.showAllCheckIns()
+      .checkOnDialog(() => cy.contains('Jaya Norris'))
+      .cancel();
+    cy.logout();
+    cy.loginAsUser(users.bl);
+
+    keyResultDetailPage
+      .visit('This keyresult is for the owner')
+      .showAllCheckIns()
+      .checkOnDialog(() => cy.contains('Jaya Norris'))
+      .editLatestCheckIn()
+      .setCheckInConfidence(7)
+      .submit();
+
+    CheckInHistoryDialog.do()
+      .checkOnDialog(() => cy.contains('Test'))
+      .checkForAttribute('Confidence:', '7 / 10')
+      .cancel();
+  });
+
   it('should create check-in metric with confidence 0', () => {
     overviewPage
       .addKeyResult()
@@ -249,6 +286,7 @@ describe('okr check-in', () => {
     cy.contains('STRETCH');
   });
 
+
   it('should display confirm dialog when creating check-in on draft objective', () => {
     overviewPage.addObjective()
       .fillObjectiveTitle('draft objective title')

diff --git a/frontend/cypress/e2e/login.cy.ts b/frontend/cypress/e2e/login.cy.ts
@@ -13,12 +13,7 @@ describe('okr login', () => {
   });
 
   it('should login and logout', () => {
-    cy.title()
-      .should('equal', 'Puzzle OKR');
-    cy.getByTestId('user-options')
-      .click();
-    cy.getByTestId('logout')
-      .click();
+    cy.logout();
     cy.origin(Cypress.env('LOGIN_URL'), () => {
       cy.url()
         .should('include', Cypress.env('LOGIN_URL'));

diff --git a/frontend/cypress/support/commands.ts b/frontend/cypress/support/commands.ts
@@ -8,6 +8,21 @@ Cypress.Commands.add('loginAsUser', (user: any) => {
   overviewIsLoaded();
 });
 
+Cypress.Commands.add('logout', () => {
+  cy.title()
+    .should('equal', 'Puzzle OKR');
+  cy.getByTestId('user-options')
+    .as('userOptions');
+  cy.get('@userOptions')
+    .click();
+
+  cy.getByTestId('logout')
+    .as('logoutButton');
+  cy.get('@logoutButton')
+    .click();
+});
+
+
 Cypress.Commands.add('getByTestId', (testId: string, text?: string): Chainable => {
   const selector = `[data-testId=${testId}]`;
 

diff --git a/frontend/cypress/support/component.ts b/frontend/cypress/support/component.ts
@@ -5,6 +5,7 @@ declare global {
   export namespace Cypress {
     interface Chainable {
       loginAsUser(user: any): Chainable;
+      logout(): void;
       getByTestId(testsId: string, text?: string): Chainable;
       findByTestId(testId: string, text?: string): Chainable;
       pressUntilContains(text: string, key: keyof typeof keyCodeDefinitions): void;

diff --git a/frontend/cypress/support/helper/dom-helper/dialogs/checkInDialog.ts b/frontend/cypress/support/helper/dom-helper/dialogs/checkInDialog.ts
@@ -82,6 +82,7 @@ export default class CheckInDialog extends Dialog {
   override submit() {
     cy.getByTestId('submit-check-in')
       .click();
+    // return new CheckInHistoryDialog();
   }
 
   getPage(): Chainable {

diff --git a/frontend/cypress/support/helper/dom-helper/dialogs/dialog.ts b/frontend/cypress/support/helper/dom-helper/dialogs/dialog.ts
@@ -7,6 +7,12 @@ export default abstract class Dialog extends PageObjectMapperBase {
     this.validatePage();
   }
 
+  checkOnDialog(check: () => void) {
+    this.getPage()
+      .within(() => check());
+    return this;
+  }
+
   override validatePage() {
     this.getPage()
       .should('exist');