Refactor duplicating methods to include values of keyResult

puzzle · Jan 13, 2025 · 33a523d · 33a523d
1 parent 829972b
commit 33a523d
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/backend/src/main/java/ch/puzzle/okr/service/business/ObjectiveBusinessService.java b/backend/src/main/java/ch/puzzle/okr/service/business/ObjectiveBusinessService.java
@@ -150,8 +150,8 @@ private KeyResult makeCopyOfKeyResultMetric(KeyResult keyResult, Objective dupli
                 .withDescription(keyResult.getDescription()) //
                 .withOwner(keyResult.getOwner()) //
                 .withUnit(((KeyResultMetric) keyResult).getUnit()) //
-                .withBaseline(0D) //
-                .withStretchGoal(1D) //
+                .withBaseline(((KeyResultMetric) keyResult).getBaseline()) //
+                .withStretchGoal(((KeyResultMetric) keyResult).getStretchGoal()) //
                 .build();
     }
 
@@ -162,9 +162,9 @@ private KeyResult makeCopyOfKeyResultOrdinal(KeyResult keyResult, Objective dupl
                 .withTitle(keyResult.getTitle()) //
                 .withDescription(keyResult.getDescription()) //
                 .withOwner(keyResult.getOwner()) //
-                .withCommitZone("-") //
-                .withTargetZone("-") //
-                .withStretchZone("-") //
+                .withCommitZone(((KeyResultOrdinal) keyResult).getCommitZone()) //
+                .withTargetZone(((KeyResultOrdinal) keyResult).getTargetZone()) //
+                .withStretchZone(((KeyResultOrdinal) keyResult).getStretchZone()) //
                 .build();
     }