make every tests name inside OverviewValidation start with should

puzzle · Dec 19, 2024 · 38db5fa · 38db5fa
1 parent e92e6a8
commit 38db5fa
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/backend/src/test/java/ch/puzzle/okr/service/validation/OverviewValidationServiceTest.java b/backend/src/test/java/ch/puzzle/okr/service/validation/OverviewValidationServiceTest.java
@@ -23,29 +23,29 @@ class OverviewValidationServiceTest {
     @InjectMocks
     OverviewValidationService validator;
 
-    @DisplayName("Should call quarter validator on validateQuarter()")
+    @DisplayName("Should be successful on validateQuarter() when quarter id is valid")
     @Test
-    void validateOnGetShouldCallQuarterValidator() {
+    void shouldBeSuccessfulOnValidateQuarterWhenQuarterIdIsValid() {
         validator.validateQuarter(QUARTER_ID);
         verify(quarterValidationService, times(1)).validateOnGet(QUARTER_ID);
         verify(quarterValidationService, times(1)).doesEntityExist(QUARTER_ID);
     }
 
-    @DisplayName("Should call team validator on validateTeam()")
+    @DisplayName("Should be successful on validateTeam() when team id is valid")
     @Test
-    void validateOnGetShouldCallTeamValidator() {
+    void shouldBeSuccessfulOnValidateTeamWhenTeamIdIsValid() {
         validator.validateTeam(TEAM_ID);
         verify(teamValidationService, times(1)).validateOnGet(TEAM_ID);
         verify(teamValidationService, times(1)).doesEntityExist(TEAM_ID);
     }
 
-    @DisplayName("Should call team validator and quarter validator on validateOnGet()")
+    @DisplayName("Should be successful on validateOnGet() when quarter and teams are valid")
     @Test
-    void validateOnGetShouldCallQuarterValidatorAndTeamValidator() {
+    void shouldBeSuccessfulOnValidateOnGetWhenQuarterAndTeamsAreValid() {
         validator.validateOnGet(QUARTER_ID, teamIds);
         verify(quarterValidationService, times(1)).validateOnGet(QUARTER_ID);
         verify(quarterValidationService, times(1)).doesEntityExist(QUARTER_ID);
         verify(teamValidationService, times(teamIds.size())).validateOnGet(anyLong());
         verify(teamValidationService, times(teamIds.size())).doesEntityExist(anyLong());
     }
-}
+}