fix objective e2e tests

puzzle · Nov 5, 2024 · 3d98dad · 3d98dad
1 parent 560f196
commit 3d98dad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/frontend/cypress/e2e/objective.cy.ts b/frontend/cypress/e2e/objective.cy.ts
@@ -100,7 +100,7 @@ describe('OKR Objective e2e tests', () => {
           .should('have.attr', 'src', `assets/icons/not-successful-icon.svg`);
       });
 
-      it(`Reopen Successful Objective`, () => {
+      it.only(`Reopen Successful Objective`, () => {
         cy.getByTestId('add-objective').first().click();
         cy.fillOutObjective('This objective will be reopened after', 'safe', undefined, '', false);
 
@@ -129,14 +129,18 @@ describe('OKR Objective e2e tests', () => {
           .contains('Objective wiedereröffnen')
           .click();
 
+        cy.contains('Objective wiedereröffnen');
+        cy.contains('Soll dieses Objective wiedereröffnet werden?');
+        cy.getByTestId('confirmYes').click();
+
         cy.getByTestId('objective')
           .filter(':contains("This objective will be reopened after")')
           .last()
           .getByTestId('objective-state')
           .should('have.attr', 'src', `assets/icons/ongoing-icon.svg`);
       });
 
-      it('Ongoing objective back to draft state', () => {
+      it.only('Ongoing objective back to draft state', () => {
         onlyOn('chrome');
         cy.getByTestId('add-objective').first().click();
         cy.fillOutObjective('This objective will be returned to draft state', 'safe', undefined, '', false);
@@ -154,7 +158,7 @@ describe('OKR Objective e2e tests', () => {
           .tabForward();
         cy.contains('Objective als Draft speichern');
         cy.contains('Soll dieses Objective als Draft gespeichert werden?');
-        cy.focused().click().wait(500);
+        cy.getByTestId('confirmYes').click();
 
         cy.getByTestId('objective')
           .filter(':contains("This objective will be returned to draft state")')

diff --git a/frontend/src/app/components/objective/ObjectiveMenuActions.ts b/frontend/src/app/components/objective/ObjectiveMenuActions.ts
@@ -60,7 +60,7 @@ export class ObjectiveMenuActions {
   }
 
   objectiveBackToDraft(): ObjectiveMenuEntry {
-    const action: ObjectiveMenuAction = () => this.dialogService.openConfirmDialog('CONFIRMATION.DRAFT_CREATE');
+    const action: ObjectiveMenuAction = () => this.dialogService.openConfirmDialog('CONFIRMATION.TO_DRAFT');
     const afterAction: ObjectiveMenuAfterAction = (obj: Objective, result: any) =>
       this.afterActions.objectiveBackToDraft(obj);