replace multiple ifs with one switch

puzzle · Dec 23, 2024 · 46643b3 · 46643b3
1 parent 1db8e05
commit 46643b3
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/frontend/cypress/support/helper/scoringSupport.ts b/frontend/cypress/support/helper/scoringSupport.ts
@@ -88,16 +88,16 @@ function checkVisibilityOfScoringComponent(isOverview: boolean, displayProperty:
 }
 
 function colorFromPercentage(percentage: number) {
-  if (percentage >= 100) {
-    return 'rgba(0, 0, 0, 0)';
-  }
-  if (percentage > 70) {
-    return 'rgb(30, 138, 41)';
-  }
-  if (percentage > 30) {
-    return 'rgb(255, 214, 0)';
+  switch (true) {
+    case percentage >= 100:
+      return 'rgba(0, 0, 0, 0)';
+    case percentage > 70:
+      return 'rgb(30, 138, 41)';
+    case percentage > 30:
+      return 'rgb(255, 214, 0)';
+    default:
+      return 'rgb(186, 56, 56)';
   }
-  return 'rgb(186, 56, 56)';
 }
 
 function scoringValueFromPercentage(percentage: number): ScoringValue {