Remove some unused code

puzzle · Dec 4, 2023 · 6d3ba2c · 6d3ba2c
1 parent 8f47ada
commit 6d3ba2c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/frontend/cypress/e2e/keyresult.cy.ts b/frontend/cypress/e2e/keyresult.cy.ts
@@ -198,7 +198,7 @@ describe('OKR Overview', () => {
     cy.contains('This is my new description');
   });
 
-  it.only('Check validation in keyresult dialog', () => {
+  it('Check validation in keyresult dialog', () => {
     cy.getByTestId('objective').first().getByTestId('add-keyResult').first().click();
     cy.getByTestId('submit').should('be.disabled');
     cy.contains('Key Result erfassen');

diff --git a/frontend/cypress/e2e/tab.cy.ts b/frontend/cypress/e2e/tab.cy.ts
@@ -209,8 +209,8 @@ describe('Tab workflow tests', () => {
       cy.focused().contains('Objective abschliessen');
       cy.realPress('Enter');
       cy.contains('Objective abschliessen');
-      cy.contains('Objective erfolgreich');
-      cy.contains('Objective nicht erfolgreich');
+      cy.contains('Objective erreicht');
+      cy.contains('Objective nicht erreicht');
       cy.tabForward();
       cy.tabForward();
       cy.realPress('Enter');

diff --git a/frontend/src/app/shared/dialog/checkin/check-in-form/check-in-form.component.html b/frontend/src/app/shared/dialog/checkin/check-in-form/check-in-form.component.html
@@ -29,7 +29,7 @@
           formControlName="changeInfo"
         ></textarea>
         <mat-error *ngIf="hasFormFieldErrors(dialogForm, 'changeInfo')">
-          <span>{{ getErrorMessage("MAX_VALUE", "Kommentar / Veränderung", 4096, null) }}</span>
+          <span>{{ getErrorMessage("MAX_VALUE", "Kommentar / Veränderung", 4096) }}</span>
         </mat-error>
       </div>
 
@@ -55,7 +55,7 @@
           formControlName="initiatives"
         ></textarea>
         <mat-error *ngIf="hasFormFieldErrors(dialogForm, 'initiatives')">
-          <span>{{ getErrorMessage("MAX_VALUE", "Massnahmen", 4096, null) }}</span>
+          <span>{{ getErrorMessage("MAX_VALUE", "Massnahmen", 4096) }}</span>
         </mat-error>
       </div>
 

diff --git a/frontend/src/app/shared/dialog/checkin/check-in-form/check-in-form.component.ts b/frontend/src/app/shared/dialog/checkin/check-in-form/check-in-form.component.ts
@@ -50,8 +50,8 @@ export class CheckInFormComponent implements OnInit {
     this.dialogForm.patchValue({ actionList: this.keyResult.actionList });
   }
 
-  getErrorMessage(error: string, field: string, firstNumber: number | null, secondNumber: number | null): string {
-    return field + this.translate.instant('DIALOG_ERRORS.' + error).format(firstNumber, secondNumber);
+  getErrorMessage(error: string, field: string, maxLength: number): string {
+    return field + this.translate.instant('DIALOG_ERRORS.' + error).format(maxLength);
   }
 
   setDefaultValues() {

diff --git a/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.ts b/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.ts
@@ -50,7 +50,7 @@ export class CompleteDialogComponent {
     });
   }
 
-  getErrorMessage(error: string, field: string, maxLength: number | null): string {
+  getErrorMessage(error: string, field: string, maxLength: number): string {
     return field + this.translate.instant('DIALOG_ERRORS.' + error).format(maxLength);
   }
 }