Skip to content

Commit

Permalink
remove the this from all variables/functions inside templates because…
Browse files Browse the repository at this point in the history
… its deprecated
  • Loading branch information
nevio18324 committed Dec 10, 2024
1 parent 9159606 commit 7173ca9
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
(keydown.arrowDown)="handleKeyDown($event, i)"
(keydown.arrowUp)="handleKeyDown($event, i)"
(focusin)="activeItem = i"
(input)="updateActionTexts(this.control.value!)"
(input)="updateActionTexts(control.value!)"
class="action-input"
[value]="action.action"
[attr.data-testId]="'actionInput'"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
<div id="topBarHeight">
<div id="okrTopbar">
<a routerLink="/" queryParamsHandling="preserve" class="d-flex h-100 align-items-center ps-4">
<img
[attr.data-testId]="'logo'"
alt="okr-logo"
height="32"
ngSrc="{{ this.logoSrc$ | async }}"
width="140"
priority
/>
<img [attr.data-testId]="'logo'" alt="okr-logo" height="32" ngSrc="{{ logoSrc$ | async }}" width="140" priority />
</a>
<div class="d-flex align-items-center me-md-5 me-1">
<button
Expand All @@ -22,7 +15,7 @@
</button>

<button
*ngIf="this.helpSiteUrl | async as helpSiteUrl"
*ngIf="helpSiteUrl | async as helpSiteUrl"
id="hilfeButton"
class="topBarEntry btn"
[attr.data-testId]="'help-button'"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ <h3 class="okr-form-label okr-form-col">Key Result</h3>
<button
(click)="saveCheckIn()"
[attr.data-testId]="'submit-check-in'"
[disabled]="!this.dialogForm.valid"
[disabled]="!dialogForm.valid"
color="primary"
mat-flat-button
type="submit"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</button>
<button mat-button mat-dialog-close color="primary" [attr.data-testId]="'cancel'">Abbrechen</button>
</div>
<div class="col-auto" *ngIf="this.data.keyResult">
<div class="col-auto" *ngIf="data.keyResult">
<button color="primary" mat-button (click)="deleteKeyResult()" [attr.data-testId]="'delete-keyResult'">
Key Result löschen
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</app-team>
<div *ngIf="(overviewEntities$ | async)?.length == 0" class="d-flex align-items-center flex-column pt-5 gap-5">
<p>Kein Team ausgewählt</p>
<img src="{{ this.backgroundLogoSrc$ | async }}" alt="Greyed out company logo" width="242" class="puzzle-logo" />
<img src="{{ backgroundLogoSrc$ | async }}" alt="Greyed out company logo" width="242" class="puzzle-logo" />
</div>
</div>
<router-outlet></router-outlet>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<button (click)="toggleAll()" class="icon-button focus-outline mt-1 me-1">
<mat-chip
[attr.data-testId]="'team-filter-alle'"
[highlighted]="activeTeams.length == (this.teams$ | async)?.length"
[highlighted]="activeTeams.length == (teams$ | async)?.length"
color="primary"
>
<p>Alle</p>
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<img alt="okr-logo" ngSrc="{{ this.trianglesSrc$ | async }}" width="274" height="140" priority />
<img alt="okr-logo" ngSrc="{{ trianglesSrc$ | async }}" width="274" height="140" priority />
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
<app-dialog-template-core [title]="dialogTitle">
<ng-container content>
<div class="linebreak bg-display-element p-2 fw-normal mb-3">
<span class="information">{{ this.dialogText.trim() }}</span>
<span class="information">{{ dialogText.trim() }}</span>
</div>
</ng-container>

<ng-container actions>
<div class="col-auto">
<button
*ngIf="this.isYesButtonVisible()"
[disabled]="this.isYesButtonDisabled()"
*ngIf="isYesButtonVisible()"
[disabled]="isYesButtonDisabled()"
[attr.data-testId]="'confirm-yes'"
type="submit"
(click)="this.closeAndDelete()"
(click)="closeAndDelete()"
color="primary"
mat-flat-button
>
Ja
</button>

<button
*ngIf="this.isNoButtonVisible()"
[disabled]="this.isNoButtonDisabled()"
*ngIf="isNoButtonVisible()"
[disabled]="isNoButtonDisabled()"
mat-button
mat-dialog-close
color="primary"
Expand All @@ -30,8 +30,8 @@
Nein
</button>
<button
*ngIf="this.isCloseButtonVisible()"
[disabled]="this.isCloseButtonDisabled()"
*ngIf="isCloseButtonVisible()"
[disabled]="isCloseButtonDisabled()"
mat-button
mat-dialog-close
color="primary"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<app-dialog-template-core [title]="getDialogTitle((this.currentTeam | async)?.name || '')">
<app-dialog-template-core [title]="getDialogTitle((currentTeam | async)?.name || '')">
<ng-container content>
<form [formGroup]="objectiveForm">
<div class="okr-form-row okr-form-label-input-container">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
>
<span class="d-flex align-items-center fw-bold add-text">
<img alt="Delete user button" class="add-cross-button" src="/assets/icons/delete-blue-icon.svg" />
{{ getFullNameFromUser(this.user) }} l&ouml;schen
{{ getFullNameFromUser(user) }} l&ouml;schen
</span>
</button>
</ng-container>

0 comments on commit 7173ca9

Please sign in to comment.