formatting changes and remove useless methode

puzzle · Jan 13, 2025 · 8453811 · 8453811
1 parent 690db09
commit 8453811
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 23 deletions.
diff --git a/backend/src/main/java/ch/puzzle/okr/repository/CompletedRepository.java b/backend/src/main/java/ch/puzzle/okr/repository/CompletedRepository.java
@@ -1,9 +1,8 @@
 package ch.puzzle.okr.repository;
 
 import ch.puzzle.okr.models.Completed;
-import org.springframework.data.repository.CrudRepository;
-
 import java.util.Optional;
+import org.springframework.data.repository.CrudRepository;
 
 public interface CompletedRepository extends CrudRepository<Completed, Long> {
     Optional<Completed> findByObjectiveId(Long objectiveId);

diff --git a/backend/src/main/java/ch/puzzle/okr/service/business/CompletedBusinessService.java b/backend/src/main/java/ch/puzzle/okr/service/business/CompletedBusinessService.java
@@ -1,18 +1,11 @@
 package ch.puzzle.okr.service.business;
 
-import ch.puzzle.okr.ErrorKey;
-import ch.puzzle.okr.exception.OkrResponseStatusException;
 import ch.puzzle.okr.models.Completed;
-import ch.puzzle.okr.models.Objective;
 import ch.puzzle.okr.service.persistence.CompletedPersistenceService;
 import ch.puzzle.okr.service.validation.CompletedValidationService;
 import jakarta.transaction.Transactional;
 import org.springframework.stereotype.Service;
 
-import java.util.List;
-
-import static org.springframework.http.HttpStatus.NOT_FOUND;
-
 @Service
 public class CompletedBusinessService {
     private final CompletedPersistenceService completedPersistenceService;

diff --git a/backend/src/main/java/ch/puzzle/okr/service/persistence/CompletedPersistenceService.java b/backend/src/main/java/ch/puzzle/okr/service/persistence/CompletedPersistenceService.java
@@ -19,6 +19,8 @@ public String getModelName() {
     }
 
     public Completed getCompletedByObjectiveId(Long objectiveId) {
-        return getRepository().findByObjectiveId(objectiveId).orElseThrow(() -> createEntityNotFoundException(objectiveId));
+        return getRepository()
+                .findByObjectiveId(objectiveId)
+                .orElseThrow(() -> createEntityNotFoundException(objectiveId));
     }
 }
diff --git a/.../src/test/java/ch/puzzle/okr/service/authorization/CompletedAuthorizationServiceTest.java b/.../src/test/java/ch/puzzle/okr/service/authorization/CompletedAuthorizationServiceTest.java
@@ -97,8 +97,8 @@ void shouldThrowExceptionWhenNotAuthorizedToGetCompletedByObjectiveId() {
                 .hasRoleReadByObjectiveId(objectiveId, authorizationUser);
 
         ResponseStatusException exception = assertThrows(ResponseStatusException.class,
-                () -> completedAuthorizationService
-                        .getCompletedByObjectiveId(objectiveId));
+                                                         () -> completedAuthorizationService
+                                                                 .getCompletedByObjectiveId(objectiveId));
         assertEquals(UNAUTHORIZED, exception.getStatusCode());
         assertEquals(reason, exception.getReason());
     }

diff --git a/backend/src/test/java/ch/puzzle/okr/service/persistence/CompletedPersistenceServiceIT.java b/backend/src/test/java/ch/puzzle/okr/service/persistence/CompletedPersistenceServiceIT.java
@@ -124,11 +124,12 @@ void getCompletedShouldGetCompletedByObjectiveId() {
     @DisplayName("Should throw exception on getCompletedByObjectiveId() when id does not exist")
     @Test
     void getCompletedShouldThrowExceptionWhenCompletedNotFound() {
-        long noExistentId = getNonExistentId();
         OkrResponseStatusException exception = assertThrows(OkrResponseStatusException.class,
-                () -> completedPersistenceService.getCompletedByObjectiveId(noExistentId));
+                                                            () -> completedPersistenceService
+                                                                    .getCompletedByObjectiveId(-1L));
 
-        List<ErrorDto> expectedErrors = List.of(new ErrorDto("MODEL_WITH_ID_NOT_FOUND",List.of(COMPLETED, String.valueOf(noExistentId))));
+        List<ErrorDto> expectedErrors = List
+                .of(new ErrorDto("MODEL_WITH_ID_NOT_FOUND", List.of(COMPLETED, String.valueOf(-1))));
 
         assertEquals(NOT_FOUND, exception.getStatusCode());
         assertThat(expectedErrors).hasSameElementsAs(exception.getErrors());
@@ -154,21 +155,15 @@ void deleteByIdShouldDeleteExistingCompletedByObjectiveId() {
     @DisplayName("Should throw exception on findById() when id does not exist")
     @Test
     void deleteCompletedShouldThrowExceptionWhenCompletedNotFound() {
-        long noExistentId = getNonExistentId();
 
         OkrResponseStatusException exception = assertThrows(OkrResponseStatusException.class,
-                                                            () -> completedPersistenceService.findById(noExistentId));
+                                                            () -> completedPersistenceService.findById(-1L));
 
         List<ErrorDto> expectedErrors = List
-                .of(new ErrorDto("MODEL_WITH_ID_NOT_FOUND", List.of(COMPLETED, String.valueOf(noExistentId))));
+                .of(new ErrorDto("MODEL_WITH_ID_NOT_FOUND", List.of(COMPLETED, String.valueOf(-1))));
 
         assertEquals(NOT_FOUND, exception.getStatusCode());
         assertThat(expectedErrors).hasSameElementsAs(exception.getErrors());
         assertTrue(TestHelper.getAllErrorKeys(expectedErrors).contains(exception.getReason()));
     }
-
-    private long getNonExistentId() {
-        long id = completedPersistenceService.findAll().stream().mapToLong(Completed::getId).max().orElse(10L);
-        return id + 10;
-    }
 }