add strict equality

puzzle · Dec 23, 2024 · 85a08b0 · 85a08b0
1 parent 8153e04
commit 85a08b0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/frontend/src/app/shared/custom/scoring/scoring.component.ts b/frontend/src/app/shared/custom/scoring/scoring.component.ts
@@ -84,7 +84,7 @@ export class ScoringComponent implements OnInit, AfterViewInit, OnChanges {
       this.targetElement.nativeElement.style.width = this.targetPercent + '%';
     }
 
-    if (this.keyResult.keyResultType == 'metric') {
+    if (this.keyResult.keyResultType === 'metric') {
       this.labelPercentage.subscribe((value) => {
         if (this.valueLabel) {
           this.valueLabel.nativeElement.style.width = value + '%';
@@ -164,9 +164,9 @@ export class ScoringComponent implements OnInit, AfterViewInit, OnChanges {
   getScoringColorClassAndSetBorder(): string | null {
     if (this.targetPercent > 100) {
       return 'score-stretch';
-    } else if (this.targetPercent > 0 || this.commitPercent == 100 && this.keyResult.keyResultType === 'metric') {
+    } else if (this.targetPercent > 0 || this.commitPercent === 100 && this.keyResult.keyResultType === 'metric') {
       return 'score-green';
-    } else if (this.commitPercent > 0 || this.failPercent == 100 && this.keyResult.keyResultType === 'metric') {
+    } else if (this.commitPercent > 0 || this.failPercent === 100 && this.keyResult.keyResultType === 'metric') {
       return 'score-yellow';
     } else if (this.failPercent >= 3.3333) {
       // 3.3333% because if lower fail is not visible in overview and we display !

diff --git a/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.ts b/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.ts
@@ -21,15 +21,16 @@ export class CompleteDialogComponent {
 
   constructor(public dialogRef: MatDialogRef<CompleteDialogComponent>,
     @Inject(MAT_DIALOG_DATA) public data: { objectiveTitle: string },
-    private translate: TranslateService) {}
+    private translate: TranslateService) {
+  }
 
   switchSuccessState(input: string) {
     this.removeStandardHover();
     let successfulValue = this.completeForm.value.isSuccessful;
     if (
       successfulValue == null ||
-      input == 'successful' && !successfulValue ||
-      input == 'notSuccessful' && successfulValue
+      input === 'successful' ||
+      input === 'notSuccessful'
     ) {
       successfulValue = input == 'successful';
       this.completeForm.patchValue({ isSuccessful: successfulValue });