#1008: minor code cleanup

puzzle · Sep 27, 2024 · 8fa1bf5 · 8fa1bf5
1 parent 26e7641
commit 8fa1bf5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/backend/src/test/java/ch/puzzle/okr/deserializer/CheckInDeserializerTest.java b/backend/src/test/java/ch/puzzle/okr/deserializer/CheckInDeserializerTest.java
@@ -87,7 +87,7 @@ private static void assertCheckInMetricDto(CheckInMetricDto checkInMetricDto) {
         assertEquals(23, checkInMetricDto.value());
     }
 
-    @DisplayName("deserialize() should return CheckInMetricDto for ordinal json")
+    @DisplayName("deserialize() should return CheckInOrdinalDto for ordinal json")
     @Test
     void deserializeShouldReturnCheckInOrdinalDtoForOrdinalJson() throws Exception {
         // arrange
@@ -168,9 +168,9 @@ public String getKeyResultType() {
         assertEquals("unsupported checkIn DTO to deserialize", responseStatusException.getReason());
     }
 
-    @DisplayName("deserialize() should throw ResponseStatusException json has no KeyResult Id")
+    @DisplayName("deserialize() should throw ResponseStatusException if json has no KeyResult Id")
     @Test
-    void deserializeShouldThrowResponseStatusExceptionJsonHasNoKeyResultId() throws Exception {
+    void deserializeShouldThrowResponseStatusExceptionIfJsonHasNoKeyResultId() throws Exception {
         // arrange
         String jsonWithoutKeyResultId = """
                 {

diff --git a/backend/src/test/java/ch/puzzle/okr/deserializer/KeyResultDeserializerTest.java b/backend/src/test/java/ch/puzzle/okr/deserializer/KeyResultDeserializerTest.java
@@ -91,18 +91,18 @@ private void assertKeyResultMetricDto(KeyResultMetricDto keyResultMetricDto) {
         assertObjective(objective);
     }
 
-    private static void assertObjective(KeyResultObjectiveDto objective) {
-        assertNotNull(objective);
-        assertEquals(1000, objective.id());
-    }
-
     private static void assertOwner(KeyResultUserDto owner) {
         assertNotNull(owner);
         assertEquals(1000, owner.id());
         assertEquals("Jaya", owner.firstname());
         assertEquals("Norris", owner.lastname());
     }
 
+    private static void assertObjective(KeyResultObjectiveDto objective) {
+        assertNotNull(objective);
+        assertEquals(1000, objective.id());
+    }
+
     @DisplayName("deserialize() should return KeyResultOrdinalDto for ordinal json")
     @Test
     void deserializeShouldReturnKeyResultOrdinalDtoForOrdinalJson() throws Exception {
@@ -193,7 +193,7 @@ void deserializeShouldThrowResponseStatusExceptionIfKeyResultIsUnsupportedType()
 
     @DisplayName("deserialize() should throw ResponseStatusException if json has no KeyResult Type")
     @Test
-    void deserializeShouldThrowResponseStatusExceptionJsonHasNoKeyResultType() throws Exception {
+    void deserializeShouldThrowResponseStatusExceptionIfJsonHasNoKeyResultType() throws Exception {
         // arrange
         String jsonMetric = """
                 {