clean up tests of objective

puzzle · Nov 7, 2024 · 9121e22 · 9121e22
1 parent 72369bb
commit 9121e22
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/frontend/src/app/components/objective/objective.component.spec.ts b/frontend/src/app/components/objective/objective.component.spec.ts
@@ -31,16 +31,11 @@ const overviewServiceMock = {
 };
 
 const objectiveServiceMock = {
-  getFullObjective(objectiveMin: ObjectiveMin) {
-    let ongoingObjective = objective;
-    ongoingObjective.state = State.ONGOING;
-    return of(ongoingObjective);
-  },
+  getFullObjective: jest.fn(),
 };
+
 describe('ObjectiveColumnComponent', () => {
   let component: ObjectiveComponent;
-  let bum: ObjectiveMenuActions;
-  let bam: ObjectiveMenuActionsService;
   let fixture: ComponentFixture<ObjectiveComponent>;
   let loader: HarnessLoader;
   beforeEach(() => {

diff --git a/frontend/src/app/services/objective-menu-actions.service.ts b/frontend/src/app/services/objective-menu-actions.service.ts
@@ -46,8 +46,7 @@ export class ObjectiveMenuActionsService {
     } else if (objective.state === State.DRAFT) {
       return this.getDraftMenuActions(objective);
     }
-    //Probably throw an error here
-    return [];
+    throw new Error('Objective invalid');
   }
 
   private getDefaultActions(objective: ObjectiveMin): ObjectiveMenuEntry[] {