implement review

puzzle · Jan 10, 2025 · af5596b · af5596b
1 parent 703a48d
commit af5596b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/backend/src/test/java/ch/puzzle/okr/mapper/checkin/helper/TestDataHelper.java b/backend/src/test/java/ch/puzzle/okr/mapper/checkin/helper/TestDataHelper.java
@@ -61,6 +61,6 @@ public static CheckInMetric checkInMetric() {
 
     public static CheckInOrdinal checkInOrdinal() {
         checkInOrdinal.setWriteable(CHECK_IN_IS_WRITEABLE);
-        return (CheckInOrdinal) TestDataHelper.checkInOrdinal;
+        return (CheckInOrdinal) checkInOrdinal;
     }
 }
diff --git a/frontend/src/app/shared/types/model/check-in-min.ts b/frontend/src/app/shared/types/model/check-in-min.ts
@@ -2,7 +2,7 @@ export interface CheckInMin {
   id?: number;
   version: number;
   confidence: number;
-  createdBy?: string;
+  createdBy: string;
   createdOn: Date;
   changeInfo: string;
   initiatives: string;