#931: UserBusinessService test for delete user by id

puzzle · Jul 30, 2024 · c36b2db · c36b2db
1 parent 687b5d1
commit c36b2db
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/backend/src/main/java/ch/puzzle/okr/service/authorization/UserAuthorizationService.java b/backend/src/main/java/ch/puzzle/okr/service/authorization/UserAuthorizationService.java
@@ -68,7 +68,7 @@ public boolean isUserOwnerOfKeyResults(long id) {
 
     public void deleteEntityById(long id) {
         // TODO check Role
-        userBusinessService.deleteUser(id);
+        userBusinessService.deleteEntityById(id);
     }
 
 }
diff --git a/backend/src/main/java/ch/puzzle/okr/service/business/UserBusinessService.java b/backend/src/main/java/ch/puzzle/okr/service/business/UserBusinessService.java
@@ -71,7 +71,8 @@ public List<User> createUsers(List<User> userList) {
     }
 
     @Transactional
-    public void deleteUser(long id) {
+    public void deleteEntityById(long id) {
+        validationService.validateOnDelete(id);
         userPersistenceService.deleteById(id);
     }
 }
diff --git a/backend/src/test/java/ch/puzzle/okr/service/business/UserBusinessServiceTest.java b/backend/src/test/java/ch/puzzle/okr/service/business/UserBusinessServiceTest.java
@@ -38,11 +38,19 @@ class UserBusinessServiceTest {
 
     @BeforeEach
     void setUp() {
-        User userAlice = User.Builder.builder().withId(2L).withFirstname("Alice").withLastname("Wunderland")
-                .withEmail("[email protected]").build();
-
-        User userBob = User.Builder.builder().withId(9L).withFirstname("Bob").withLastname("Baumeister")
-                .withEmail("[email protected]").build();
+        User userAlice = User.Builder.builder() //
+                .withId(2L) //
+                .withFirstname("Alice") //
+                .withLastname("Wunderland") //
+                .withEmail("[email protected]") //
+                .build();
+
+        User userBob = User.Builder.builder() //
+                .withId(9L) //
+                .withFirstname("Bob") //
+                .withLastname("Baumeister") //
+                .withEmail("[email protected]") //
+                .build();
 
         userList = Arrays.asList(userAlice, userBob);
     }
@@ -162,4 +170,11 @@ void setOkrChampion_shouldNotThrowExceptionIfSecondLastOkrChampIsRemoved() {
         verify(userPersistenceService, times(1)).save(user);
         assertFalse(user.isOkrChampion());
     }
+
+    @Test
+    void shouldDeleteUser() {
+        userBusinessService.deleteEntityById(23L);
+
+        verify(userPersistenceService, times(1)).deleteById(23L);
+    }
 }