Add a couple more semantic tags

puzzle · Oct 18, 2024 · e242be3 · e242be3
1 parent f7d2a80
commit e242be3
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/frontend/package.json b/frontend/package.json
@@ -3,7 +3,7 @@
   "version": "2.0.0",
   "scripts": {
     "ng": "ng",
-    "start": "ng serve ",
+    "start": "ng serve --host 0.0.0.0",
     "build": "ng build",
     "build:staging": "ng build --configuration staging",
     "watch": "ng build --watch --configuration development",

diff --git a/frontend/src/app/app.component.html b/frontend/src/app/app.component.html
@@ -1,2 +1,6 @@
-<app-application-top-bar></app-application-top-bar>
-<router-outlet></router-outlet>
+<header>
+  <app-application-top-bar></app-application-top-bar>
+</header>
+<main>
+  <router-outlet></router-outlet>
+</main>
diff --git a/frontend/src/app/components/application-top-bar/application-top-bar.component.html b/frontend/src/app/components/application-top-bar/application-top-bar.component.html
@@ -1,4 +1,4 @@
-<header id="topBarHeight">
+<div id="topBarHeight">
   <div id="okrTopbar">
     <span class="d-flex h-100 align-items-center ps-4">
       <img alt="okr-logo" height="32" ngSrc="{{ this.logoSrc$ | async }}" width="140" />
@@ -49,4 +49,4 @@
       </button>
     </mat-menu>
   </div>
-</header>
+</div>
diff --git a/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html b/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html
@@ -13,7 +13,7 @@
       <div class="input-style gap-2 col-12">
         <label class="text-black">Bewertung</label>
         <div class="d-flex gap-3">
-          <div
+          <span
             class="successful w-50 valuation-card card-hover-successful"
             [ngClass]="{
               'active-successful': completeForm.value.isSuccessful == true,
@@ -25,8 +25,8 @@
             tabindex="0"
           >
             Objective erreicht
-          </div>
-          <div
+          </span>
+          <span
             class="not-successful w-50 valuation-card card-hover-not-successful"
             [ngClass]="{
               'active-not-successful': completeForm.value.isSuccessful === false,
@@ -38,7 +38,7 @@
             tabindex="0"
           >
             Objective nicht erreicht
-          </div>
+          </span>
         </div>
       </div>