Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1024 fix disabled tests #1036

Closed
wants to merge 29 commits into from
Closed

Conversation

Miguel7373
Copy link
Collaborator

No description provided.

@Miguel7373 Miguel7373 linked an issue Oct 15, 2024 that may be closed by this pull request
@Miguel7373 Miguel7373 marked this pull request as ready for review October 15, 2024 11:12
@peggimann peggimann force-pushed the bug/1024-fix-disabled-tests branch from 9b9638b to 880a124 Compare October 18, 2024 15:00
frontend/package.json Outdated Show resolved Hide resolved
@Miguel7373 Miguel7373 requested a review from peggimann October 21, 2024 08:54
@peggimann peggimann force-pushed the dev branch 2 times, most recently from 9d85100 to c067be8 Compare October 23, 2024 09:39
@RandomTannenbaum RandomTannenbaum marked this pull request as draft October 23, 2024 09:50
@RandomTannenbaum RandomTannenbaum removed the request for review from peggimann October 23, 2024 09:50
@ManuelMoeri ManuelMoeri force-pushed the bug/1024-fix-disabled-tests branch from e8ef75f to 18e0242 Compare October 25, 2024 12:02
clean-coder and others added 5 commits October 25, 2024 15:43
* jar is now debuggable

* rename folder

* add a Observable that triggers a refresh when called

* add destroy observable to stop subscription of reloadKeySubject

* add tests to observables

---------

Co-authored-by: Yanick Minder <[email protected]>
* tests for PersistenceBase class

* remove tests from QuarterPersistenceServiceIT which are already covered in PersistenceBaseTestIT

* remove no longer used OrganisationXXX() methods

* remove tests from TeamPersistenceServiceIT which are already covered in PersistenceBaseTestIT

* remove tests from UserPersistenceServiceIT which are already covered in PersistenceBaseTestIT and add additional tests

* remove tests from CheckInPersistenceServiceIT which are already covered in PersistenceBaseTestIT and add additional test

* umbau ObjectivePersistenceServiceIT: remove tests which are already covered in PersistenceBaseTestIT, add additional test, make the tests readable

* tests for AuthorizationCriteria

* tests for AuthorizationCriteria

* tests for AuthorizationCriteria

* enable debug trace

* debug found okr-champions in test

* add logging in findAllOkrChampionsShouldReturnAllOkrChampions() test

* disable tests which call setOkrChampion()

* enable some disabled tests

* enable some disabled tests

* enable last disabled test .. should fail

* ugly temp fix

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

---------

Co-authored-by: peggimann <[email protected]>
* add jar debug dev tools only on profile

* refactor dialog calls with config by introducing a service

* convert all confirmation dialog texts to i18n texts

* use refactored  confirmation component

* fix string and use interface for confirm dialog data

* Update title of delete confirmation

* clean up dialog service

* refactor frontend tests related to dialogService

* display correct dialog in objective

* fix objective release dialog

* refactor dialog responsiveness

* clean up dialog service

* remove backend/pom.xml from branch

* update translations and fix release dialog

* update dialog.service.ts
@Miguel7373 Miguel7373 force-pushed the bug/1024-fix-disabled-tests branch from 7833723 to 0791458 Compare October 28, 2024 07:12
@Miguel7373 Miguel7373 marked this pull request as ready for review October 28, 2024 10:03
@Miguel7373 Miguel7373 marked this pull request as draft October 28, 2024 10:06
@peggimann peggimann force-pushed the dev branch 2 times, most recently from 536555b to ae11e13 Compare October 30, 2024 10:33
@MasterEvarior MasterEvarior force-pushed the dev branch 3 times, most recently from b5b9628 to 0f20ba6 Compare October 31, 2024 15:00
@MasterEvarior MasterEvarior force-pushed the dev branch 2 times, most recently from be0495f to edd0dee Compare November 6, 2024 07:23
@RandomTannenbaum
Copy link
Collaborator

Seems to already be fixed

@peggimann peggimann deleted the bug/1024-fix-disabled-tests branch November 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix disabled tests
7 participants