Feature/624 Dialog creation refactoring using a service #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcinay055679
force-pushed
the
feature/624-mobile-dialogs
branch
2 times, most recently
from
95954db to
894d496
Compare
kcinay055679
force-pushed
the
feature/624-mobile-dialogs
branch
from
f297a6b to
f7083e4
Compare
kcinay055679
changed the title
Closed
3 tasks
kcinay055679
force-pushed
the
feature/624-mobile-dialogs
branch
2 times, most recently
from
cb9f330 to
b1222ad
Compare
kcinay055679
changed the title
kcinay055679
force-pushed
the
feature/624-mobile-dialogs
branch
from
c6ffc78 to
4e4bd05
Compare
peggimann
force-pushed
the
feature/624-mobile-dialogs
branch
from
4e4bd05 to
0bf52b6
Compare
peggimann
approved these changes
Oct 25, 2024
frontend/src/app/shared/dialog/confirm-dialog/confirm-dialog.component.ts
Show resolved
Hide resolved
kcinay055679
force-pushed
the
feature/624-mobile-dialogs
branch
from
a5bf9ef to
1aba91f
Compare
kcinay055679
added a commit
that referenced
this pull request
Oct 25, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
peggimann
pushed a commit
that referenced
this pull request
Oct 30, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
peggimann
pushed a commit
that referenced
this pull request
Oct 30, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
MasterEvarior
pushed a commit
that referenced
this pull request
Oct 30, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
MasterEvarior
pushed a commit
that referenced
this pull request
Oct 31, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
MasterEvarior
pushed a commit
that referenced
this pull request
Oct 31, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
peggimann
pushed a commit
that referenced
this pull request
Nov 1, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
MasterEvarior
pushed a commit
that referenced
this pull request
Nov 6, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
MasterEvarior
pushed a commit
that referenced
this pull request
Nov 6, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
MasterEvarior
pushed a commit
that referenced
this pull request
Nov 7, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
peggimann
added a commit
that referenced
this pull request
Nov 8, 2024
* remove cnAttributesMapper and all the related files * remove ldab properties and dependency * update config * auto restart spring if jar changes * jar is now debuggable * add jar debug dev tools only on profile * change log levels * try to fix autorestart of spring * complete auto restart of container * rename intelij config and change log level of spring to debug in staging config * rename folder * exclude formatter plugin in build for docker * use external profile to disable formatter * clean up * update local prod dockerfile * fix display of tangram * update test and change const cname * add logging to QuarterFunction (#1076) * add a Observable that triggers a refresh when called (#1041) * jar is now debuggable * rename folder * add a Observable that triggers a refresh when called * add destroy observable to stop subscription of reloadKeySubject * add tests to observables --------- Co-authored-by: Yanick Minder <[email protected]> * #1030: tests for delete() and deleteAll() (#1034) * Test/1012 service (#1050) * tests for PersistenceBase class * remove tests from QuarterPersistenceServiceIT which are already covered in PersistenceBaseTestIT * remove no longer used OrganisationXXX() methods * remove tests from TeamPersistenceServiceIT which are already covered in PersistenceBaseTestIT * remove tests from UserPersistenceServiceIT which are already covered in PersistenceBaseTestIT and add additional tests * remove tests from CheckInPersistenceServiceIT which are already covered in PersistenceBaseTestIT and add additional test * umbau ObjectivePersistenceServiceIT: remove tests which are already covered in PersistenceBaseTestIT, add additional test, make the tests readable * tests for AuthorizationCriteria * tests for AuthorizationCriteria * tests for AuthorizationCriteria * enable debug trace * debug found okr-champions in test * add logging in findAllOkrChampionsShouldReturnAllOkrChampions() test * disable tests which call setOkrChampion() * enable some disabled tests * enable some disabled tests * enable last disabled test .. should fail * ugly temp fix * cleanup * cleanup * cleanup * cleanup * cleanup * cleanup --------- Co-authored-by: peggimann <[email protected]> * Feature/624 Dialog creation refactoring using a service (#1045) * add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts * create tests for dialog-service (#1112) * Feature/1032 update javaversion (#1103) * change java version to 21 * edit java version in pom and edit version in pipes to github action variable * add generic version to name strings --------- Co-authored-by: Nevio Di Gennaro <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * Get current quarter from backend (#1039) * add auto data-migration * jar is now debuggable * add jar debug dev tools only on profile * change log levels * try to fix autorestart of spring * complete auto restart of container * rename intelij config and change log level of spring to debug in staging config * rename folder * update docker compose file * use external profile to disable formatter * clean up * add jar debug dev tools only on profile * add api endpoint * use api to get current quarter * convert quarter to a class instead of an interface * use class syntax * update specs to use the class syntax for quarters * mock new class function in test * add integratin test for current quarter endpoint * fix default quarter for new objective selection * use v2 for quarter url and update tests accoridingly * change merhod to fakeAsync * try to override provider mid test * Dispatch change instead of input event in onSubmit create test and get element by test id instead of id * Remove duplicate profile in pom * Update swagger annotations of get current quarter and fix usage of wrong implementation class for get current quarters * Remove unused import in common.ts * add dependency for hot reload in again * [FM] Automated formating frontend * readd local debug run config --------- Co-authored-by: Miguel Lehmann <[email protected]> Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * fix git history (#1124) * Fix/fix git history (#1125) * fix history * fix hist * refactor styles of dialogs (#1072) * add jar debug dev tools only on profile * change log levels * try to fix autorestart of spring * rename intelij config and change log level of spring to debug in staging config * rename folder * use external profile to disable formatter * remove backend/pom.xml from branch * refactor styles of dialogs * remove useless tabindex * refactor styling of dialog-content and dialog-actions * refactor dialog header * clean up * fix invite members test * change default width of dialog * set cypress viewport * remove it.only from cy tests * use diffrent classes for default and small dialogs * remove useless config * clean up styling * remove scroll-shaddow * change height sizing strategie * refactor styling of keyresult edit component * introduce dialog-template-core-component * create base template for dialogs * align close button * comment in dialog component * fix scrolling of dialog * refactor kr-type-form * finish styling of kr-type select * fix scrolling by setting height of action buttons * clean up dialog content size * clean up styles.scss * refactor styles * refactor styles of generic component * move core component to shared module * fix design because of scrollbar * change keyresult type tabs to butotns * delete cancel dialog and refactor related files * refactor confirm dialog component to use template dialog core * refactor styling * refactor style of okr-label * refactor example dialog * refactor objective form component to use template dialog core * refactor objective form dialog * refactor dialog width * refactor keyresult component * fix responsive dialog * refactor objective complete dialog * clean up * refactor objective form component * minder out * fix objective form component * use priority to fetch logos * refactor dialog history compoennt * add spinner to dialog core * refactor dialog history component * refactor check-in componentn * refactor metric check in component * clean up keyresult dialog * clean up * fix kr type component * finish dialog refactoring * remove header component * refactor css classes * refactor styling * insert okr-form-label-input-container * fix dialog service tests * fix jest of objective form compoennt * fix tests of keyresult form * fix pom * fix tests of add-edit team dialog * fix tests keyresult-dialog tests * fix tests of complete dialog * fix jest tests * readd cancel button for check-in create * fix check-in e2e tests * fix e2e tests * remove only from cypress tests * fix teammanagement e2e test * fix duplicate scorring * clean up check-in tests * fix objective duplicate tests * clean up * clean up styles * create a dialog-data-show class * fix check in metric * fix keyresult type * clean up * implement todo --------- Co-authored-by: peggimann <[email protected]> * Bug/1013 routing to overview (#1084) * Add permanent teamverwaltung button and make logo route to / * Make router links leading to homepage preserve query params * Change tag around logo from span to a * Add e2e tests that test if route is preserved --------- Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * Feature/624 refactor objective menu (#1078) * Fix/fix git history (#1125) * fix history * fix hist * jar is now debuggable * add jar debug dev tools only on profile * rename intelij config and change log level of spring to debug in staging config * rename folder * update docker compose file * use external profile to disable formatter * clean up * refactor dialog calls with config by introducing a service * refactor frontend tests related to dialogService * remove backend/pom.xml from branch * introduce new objective menu action service to simplify dialog creation of dialog actions * refactor objective * reimplement generic menu * use pipe with map to generate menu entries * introduce afterAction property * add ObjectiveAfterActionFactory * introduce objectiveMenuAction file * refactor objective status tooltip * clean up objective menu action service * rename objective actions file * Try to fix frontend unit tests * restore staging.properties * fix angular build * place functions in related files instead of common.ts * restore angular config files * fix action service tests * add test for actions service * clean up * display correct options for draft and use replay subject * fix check-in tests * fix objective backlog tests * fix objective e2e tests * fix tabbing tests * fix tabbing tests * schtibitz e2e strategy from pulfer * remove console.log * restore focus * restore old frontend-test-action * clean pup * remove application.staging from pr * clean up tests of objective * fix e2e tests * check for focues of threedot menu after dialog closes --------- Co-authored-by: Manuel <[email protected]> * Bug/845-chf-label (#1106) * jar is now debuggable * rename intelij config and change log level of spring to debug in staging config * Fix bug with double label in check in history * delete unused pipe and edit the CHF output * edit e2e and frontend tests to work with the new format * remove lable pipe in dialog * add second pipe back in and edit to suffix * fix tests and refactor value pipe * fix spec tests for pipes * fix e2e tests * remove space before percent * fix unit-lable spec and e2e tests * fix spaceing of percent in tests * add testId --------- Co-authored-by: Yanick Minder <[email protected]> Co-authored-by: Lias Kleisa <[email protected]> * Feature/977 HTML structure (#1040) * Implement html structure and fix tests * Shorten logic in component * Remove unwanted styling that broke every dialog * Add styling to headings and fix obvious mistakes * Fix font size in banner and alignment of stretch star * Fix e2e test * Remove files that do not belong to my PR * Fix bug with checked item (#1138) --------- Co-authored-by: Miguel Lehmann <[email protected]> Co-authored-by: Yanick Minder <[email protected]> Co-authored-by: Jean-Claude Brantschen <[email protected]> Co-authored-by: nevio18324 <[email protected]> Co-authored-by: peggimann <[email protected]> Co-authored-by: Yanick Minder <[email protected]> Co-authored-by: Miguel <[email protected]> Co-authored-by: Nevio Di Gennaro <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: Manuel <[email protected]> Co-authored-by: Lias Kleisa <[email protected]> Co-authored-by: Manuel <[email protected]>
kcinay055679
added a commit
that referenced
this pull request
Nov 11, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
kcinay055679
added a commit
that referenced
this pull request
Nov 11, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
RandomTannenbaum
pushed a commit
that referenced
this pull request
Nov 15, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
kcinay055679
added a commit
that referenced
this pull request
Nov 15, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
kcinay055679
added a commit
that referenced
this pull request
Nov 15, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
peggimann
pushed a commit
that referenced
this pull request
Nov 15, 2024
* update config * jar is now debuggable * add jar debug dev tools only on profile * change log levels * try to fix autorestart of spring * rename intelij config and change log level of spring to debug in staging config * exclude formatter plugin in build for docker * use external profile to disable formatter * clean up * fix display of tangram * update test and change const cname * add a Observable that triggers a refresh when called (#1041) * jar is now debuggable * rename folder * add a Observable that triggers a refresh when called * add destroy observable to stop subscription of reloadKeySubject * add tests to observables --------- Co-authored-by: Yanick Minder <[email protected]> * Feature/624 Dialog creation refactoring using a service (#1045) * add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts * create tests for dialog-service (#1112) * Get current quarter from backend (#1039) * add auto data-migration * jar is now debuggable * add jar debug dev tools only on profile * change log levels * try to fix autorestart of spring * complete auto restart of container * rename intelij config and change log level of spring to debug in staging config * rename folder * update docker compose file * use external profile to disable formatter * clean up * add jar debug dev tools only on profile * add api endpoint * use api to get current quarter * convert quarter to a class instead of an interface * use class syntax * update specs to use the class syntax for quarters * mock new class function in test * add integratin test for current quarter endpoint * fix default quarter for new objective selection * use v2 for quarter url and update tests accoridingly * change merhod to fakeAsync * try to override provider mid test * Dispatch change instead of input event in onSubmit create test and get element by test id instead of id * Remove duplicate profile in pom * Update swagger annotations of get current quarter and fix usage of wrong implementation class for get current quarters * Remove unused import in common.ts * add dependency for hot reload in again * [FM] Automated formating frontend * readd local debug run config --------- Co-authored-by: Miguel Lehmann <[email protected]> Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * Fix/fix git history (#1125) * fix history * fix hist * refactor styles of dialogs (#1072) * add jar debug dev tools only on profile * change log levels * try to fix autorestart of spring * rename intelij config and change log level of spring to debug in staging config * rename folder * use external profile to disable formatter * remove backend/pom.xml from branch * refactor styles of dialogs * remove useless tabindex * refactor styling of dialog-content and dialog-actions * refactor dialog header * clean up * fix invite members test * change default width of dialog * set cypress viewport * remove it.only from cy tests * use diffrent classes for default and small dialogs * remove useless config * clean up styling * remove scroll-shaddow * change height sizing strategie * refactor styling of keyresult edit component * introduce dialog-template-core-component * create base template for dialogs * align close button * comment in dialog component * fix scrolling of dialog * refactor kr-type-form * finish styling of kr-type select * fix scrolling by setting height of action buttons * clean up dialog content size * clean up styles.scss * refactor styles * refactor styles of generic component * move core component to shared module * fix design because of scrollbar * change keyresult type tabs to butotns * delete cancel dialog and refactor related files * refactor confirm dialog component to use template dialog core * refactor styling * refactor style of okr-label * refactor example dialog * refactor objective form component to use template dialog core * refactor objective form dialog * refactor dialog width * refactor keyresult component * fix responsive dialog * refactor objective complete dialog * clean up * refactor objective form component * minder out * fix objective form component * use priority to fetch logos * refactor dialog history compoennt * add spinner to dialog core * refactor dialog history component * refactor check-in componentn * refactor metric check in component * clean up keyresult dialog * clean up * fix kr type component * finish dialog refactoring * remove header component * refactor css classes * refactor styling * insert okr-form-label-input-container * fix dialog service tests * fix jest of objective form compoennt * fix tests of keyresult form * fix pom * fix tests of add-edit team dialog * fix tests keyresult-dialog tests * fix tests of complete dialog * fix jest tests * readd cancel button for check-in create * fix check-in e2e tests * fix e2e tests * remove only from cypress tests * fix teammanagement e2e test * fix duplicate scorring * clean up check-in tests * fix objective duplicate tests * clean up * clean up styles * create a dialog-data-show class * fix check in metric * fix keyresult type * clean up * implement todo --------- Co-authored-by: peggimann <[email protected]> * Bug/1013 routing to overview (#1084) * Add permanent teamverwaltung button and make logo route to / * Make router links leading to homepage preserve query params * Change tag around logo from span to a * Add e2e tests that test if route is preserved --------- Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * Feature/624 refactor objective menu (#1078) * Fix/fix git history (#1125) * fix history * fix hist * jar is now debuggable * add jar debug dev tools only on profile * rename intelij config and change log level of spring to debug in staging config * rename folder * update docker compose file * use external profile to disable formatter * clean up * refactor dialog calls with config by introducing a service * refactor frontend tests related to dialogService * remove backend/pom.xml from branch * introduce new objective menu action service to simplify dialog creation of dialog actions * refactor objective * reimplement generic menu * use pipe with map to generate menu entries * introduce afterAction property * add ObjectiveAfterActionFactory * introduce objectiveMenuAction file * refactor objective status tooltip * clean up objective menu action service * rename objective actions file * Try to fix frontend unit tests * restore staging.properties * fix angular build * place functions in related files instead of common.ts * restore angular config files * fix action service tests * add test for actions service * clean up * display correct options for draft and use replay subject * fix check-in tests * fix objective backlog tests * fix objective e2e tests * fix tabbing tests * fix tabbing tests * schtibitz e2e strategy from pulfer * remove console.log * restore focus * restore old frontend-test-action * clean pup * remove application.staging from pr * clean up tests of objective * fix e2e tests * check for focues of threedot menu after dialog closes --------- Co-authored-by: Manuel <[email protected]> * Bug/845-chf-label (#1106) * jar is now debuggable * rename intelij config and change log level of spring to debug in staging config * Fix bug with double label in check in history * delete unused pipe and edit the CHF output * edit e2e and frontend tests to work with the new format * remove lable pipe in dialog * add second pipe back in and edit to suffix * fix tests and refactor value pipe * fix spec tests for pipes * fix e2e tests * remove space before percent * fix unit-lable spec and e2e tests * fix spaceing of percent in tests * add testId --------- Co-authored-by: Yanick Minder <[email protected]> Co-authored-by: Lias Kleisa <[email protected]> * Feature/977 HTML structure (#1040) * Implement html structure and fix tests * Shorten logic in component * Remove unwanted styling that broke every dialog * Add styling to headings and fix obvious mistakes * Fix font size in banner and alignment of stretch star * Fix e2e test * Remove files that do not belong to my PR * Fix bug with checked item (#1138) * fix isCurrent method * add test to test if aktuell label is shown * make test check if the quarter with aktuell label is actually the current quarter * fix e2e test * update e2e intelij config version * restore pom.xml --------- Co-authored-by: nevio18324 <[email protected]> Co-authored-by: Miguel Lehmann <[email protected]> Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: peggimann <[email protected]> Co-authored-by: Manuel <[email protected]> Co-authored-by: Miguel <[email protected]> Co-authored-by: Lias Kleisa <[email protected]> Co-authored-by: Manuel <[email protected]> Co-authored-by: Nevio Di Gennaro <[email protected]>
RandomTannenbaum
pushed a commit
that referenced
this pull request
Nov 15, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
RandomTannenbaum
pushed a commit
that referenced
this pull request
Nov 19, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
nevio18324
pushed a commit
that referenced
this pull request
Nov 21, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
kcinay055679
added a commit
that referenced
this pull request
Nov 21, 2024
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I refactored the way dialogs are opened by introducing a Dialog Service. This service simplifies the creation of a responsive dialog configuration, with responsiveness based on Bootstrap.