Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/710 url to supportsite #1175

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Conversation

nevio18324
Copy link
Collaborator

No description provided.

@nevio18324 nevio18324 force-pushed the feature/710-url-to-supportsite branch from 2d7b1b0 to d592e34 Compare November 19, 2024 10:37
@nevio18324 nevio18324 linked an issue Nov 19, 2024 that may be closed by this pull request
@nevio18324 nevio18324 force-pushed the feature/710-url-to-supportsite branch 3 times, most recently from e454e53 to 094920c Compare November 19, 2024 12:15
@nevio18324 nevio18324 force-pushed the feature/710-url-to-supportsite branch from 4cd4527 to 11cc672 Compare November 19, 2024 12:50
Copy link
Collaborator

@kcinay055679 kcinay055679 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@peggimann peggimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good job. Naming should be edited. Also pay attention to details.

@nevio18324 nevio18324 marked this pull request as ready for review November 21, 2024 08:17
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@MasterEvarior MasterEvarior merged commit ce699f6 into dev Nov 21, 2024
5 checks passed
@MasterEvarior MasterEvarior deleted the feature/710-url-to-supportsite branch November 21, 2024 09:09
@MasterEvarior MasterEvarior restored the feature/710-url-to-supportsite branch November 21, 2024 09:09
@MasterEvarior MasterEvarior removed a link to an issue Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants