refactoring/1171 naming cleanup #1210
Draft
+2,911
−2,537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
20 tasks
backend/src/main/java/ch/puzzle/okr/dto/overview/DashboardDto.java
Outdated
Show resolved
Hide resolved
...end/src/test/java/ch/puzzle/okr/service/persistence/AuthorizationCriteriaParametersTest.java
Outdated
Show resolved
Hide resolved
ManuelMoeri
requested changes
Dec 16, 2024
backend/src/main/java/ch/puzzle/okr/service/business/ObjectiveBusinessService.java
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/architecture/OkrArchitectureTest.java
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/mapper/ActionMapperTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/ch/puzzle/okr/multitenancy/SchemaMultiTenantConnectionProviderInternalsTest.java
Show resolved
Hide resolved
| @Test | ||
| void getTenantFromClaimsSetUsingClaimTenantReturnTenantIfClaimTenantFound() throws ParseException { | ||
| void getTenantFromClaimsSetUsingClaimTenantReturnsTenantIfClaimTenantFound() throws ParseException { |
There was a problem hiding this comment.
Maybe check if this can be simplified. I had to re-read this like 3 times 🧠
backend/src/test/java/ch/puzzle/okr/service/persistence/CheckInPersistenceServiceIT.java
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/util/quarter/check/QuarterRangeCheckerTest.java
Show resolved
Hide resolved
RandomTannenbaum
force-pushed
the
refactoring/1171-naming-cleanup
branch
from
d4cb36c to
8c3fc2b
Compare
RandomTannenbaum
force-pushed
the
refactoring/1171-naming-cleanup
branch
from
8c3fc2b to
4ebacfa
Compare
… for the standalone files
… describe the test
…ming-cleanup' into refactoring/1171-naming-cleanup
…ming-cleanup' into refactoring/1171-naming-cleanup
…ld and delete duplicated tests
…ming-cleanup' into refactoring/1171-naming-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.