Feature/1135 Apply Formatters #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
peggimann
requested changes
Nov 27, 2024
backend/src/main/java/ch/puzzle/okr/OpenAPI30Configuration.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/controller/ActionController.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/controller/AlignmentController.java
Outdated
Show resolved
Hide resolved
kcinay055679
force-pushed
the
feature/1135-formatter
branch
from
b01bea4 to
f459916
Compare
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
3 times, most recently
from
3153551 to
968a583
Compare
peggimann
requested changes
Nov 29, 2024
backend/src/main/java/ch/puzzle/okr/dto/keyresult/KeyResultLastCheckInOrdinalDto.java
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/mapper/AlignmentSelectionMapper.java
Show resolved
Hide resolved
frontend/src/app/components/application-top-bar/application-top-bar.component.html
Outdated
Show resolved
Hide resolved
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
from
66b5ea4 to
b867dc2
Compare
kcinay055679
force-pushed
the
feature/1135-formatter
branch
from
aeed53a to
5f7f93e
Compare
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
from
c88134c to
5816993
Compare
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
from
5816993 to
22aaa9f
Compare
kcinay055679
force-pushed
the
feature/1135-formatter
branch
2 times, most recently
from
70c60c5 to
52e59c4
Compare
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
6 times, most recently
from
995ec42 to
3f1aeb8
Compare
kcinay055679
force-pushed
the
feature/1135-formatter
branch
from
419743d to
c58536d
Compare
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
4 times, most recently
from
1cf9c5d to
528086d
Compare
kcinay055679
force-pushed
the
feature/1135-formatter
branch
2 times, most recently
from
b5572f9 to
40b83c3
Compare
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
4 times, most recently
from
0d052c6 to
5f0b08f
Compare
backend/src/main/java/ch/puzzle/okr/deserializer/DeserializerHelper.java
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/dto/keyresult/KeyResultMetricDto.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/mapper/keyresult/KeyResultMapper.java
Show resolved
Hide resolved
frontend/src/app/components/application-banner/application-banner.component.html
Show resolved
Hide resolved
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
2 times, most recently
from
4a4be4a to
7c97437
Compare
kcinay055679
force-pushed
the
feature/1135-formatter
branch
from
02dc127 to
3805119
Compare
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
from
7c97437 to
1e8b259
Compare
kcinay055679
force-pushed
the
feature/1135-formatter-apply
branch
from
1e8b259 to
8d67841
Compare
peggimann
approved these changes
Dec 20, 2024
kcinay055679
added a commit
that referenced
this pull request
Dec 20, 2024
* run frontend formatter * run backend formatter * update package-lock * apply formatter * run formatter * run prettier --------- Co-authored-by: Yanick Minder <[email protected]>
peggimann
pushed a commit
that referenced
this pull request
Dec 20, 2024
* introduce spotless formatter * update readme and pipeline * add typescript formatter * add frontedn config * update tsconfig.json * install eslint for formating * update typescript-eslint to 8.15.0 * edit config * put unused-imports plugin into config * change config for spec files * add stylistic plugin to eslnt * add eslint stylistic rules * update config for eslint stylic * styling indent set to 2 * add html formatting * extract eslint format in seperated command * readd prettier for css json and yaml * update eslint config * disable check for multipline tenary * refactor config to extract rules to apply only on ts files * allow arguments * Update excluded eslint rules that we want to resolve in follow up ticket * Fix sentence in readme * Allow ts-ignores * remove unnecessary comma * Replace javax with jakarta in import order property of formatter * get all changes from apply branch * update precommit hook * update backend formatter * update java import order to alphabetically * fix backend formatter for annotations * update formatting config to fix indentation of annonation params * update formatter to improve parameter formatting * update parameter formatting * update formatter * add space after array initializer * update precommit hook * precommit hook only updates changed files * clean up pre-commit hook * remove accidently added fiels * remove objective from this pr * add verbose option to git add in precommit hook * remove objective model from pr * remove debug log * restore objective model * add angular eslint config * clean up frontend formatter config * add scss to eslint config * rename npm scripts * use json eslint plugin and remove prettier * use prettier again to format scss * add prettierignore file * configure prettier * update precommit hook to use prettier * replace new lines with space to read changed files * exclude files without extension from formatting * fix pre-commit hook * update name of package scripts and update workflow * readd ignored files to prettierrc * clean up * clean up * remove logs from pre-commit * remove files from pr * update frontend config * allow empty constructors * update config * update prettirrc * update config * use old html formatter * rmeove xargs from precommit hook * update config for html files * updat package lock * clean up eslint config and packages * change formatting dependencies to dev dep and regen package-lock * update formatter * update frontend formatter * update formatter * Feature/1135 Apply Formatters (#1221) * run frontend formatter * run backend formatter * update package-lock * apply formatter * run formatter * run prettier --------- Co-authored-by: Yanick Minder <[email protected]> --------- Co-authored-by: Miguel Lehmann <[email protected]> Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: Jannik Pulfer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.