Bug/1255 Duplicating a objective does not bring all properties of the KeyResults #1294

ManuelMoeri · 2025-01-13T10:23:11Z

No description provided.

MasterEvarior

Overall it looks already quite good. There are a couple of minor things and also the the organization of the code that should be improved.

backend/src/main/java/ch/puzzle/okr/service/business/ObjectiveBusinessService.java

backend/src/main/java/ch/puzzle/okr/service/persistence/ActionPersistenceService.java

backend/src/main/java/ch/puzzle/okr/service/business/ActionBusinessService.java

frontend/src/app/services/objective.service.ts

frontend/cypress/e2e/duplicate-objective.cy.ts

backend/src/test/java/ch/puzzle/okr/service/persistence/ActionPersistenceServiceIT.java

backend/src/test/java/ch/puzzle/okr/controller/ObjectiveControllerIT.java

backend/src/main/java/ch/puzzle/okr/models/keyresult/KeyResult.java

backend/src/main/java/ch/puzzle/okr/service/business/ObjectiveBusinessService.java

backend/src/main/java/ch/puzzle/okr/service/business/KeyResultBusinessService.java

backend/src/test/java/ch/puzzle/okr/service/business/ActionBusinessServiceTest.java

frontend/cypress/e2e/duplicate-objective.cy.ts

…xcept id

Co-authored-by: MasterEvarior <[email protected]>

backend/src/test/java/ch/puzzle/okr/service/business/ActionBusinessServiceTest.java

MasterEvarior

🎉 🎉

Stale

ManuelMoeri linked an issue Jan 13, 2025 that may be closed by this pull request

Duplizieren eines Objectives übernimmt nicht alle Eigenschaften #1255

Closed

19 tasks

nevio18324 requested a review from RandomTannenbaum January 14, 2025 12:05

nevio18324 force-pushed the bug/1255-duplicating-of-objective-should-bring-all-properties branch from d8561be to f090a48 Compare January 14, 2025 12:20

nevio18324 marked this pull request as ready for review January 14, 2025 14:29

ManuelMoeri requested review from MasterEvarior and removed request for RandomTannenbaum January 15, 2025 06:54

MasterEvarior requested changes Jan 15, 2025

View reviewed changes

peggimann previously requested changes Jan 15, 2025

View reviewed changes

ManuelMoeri requested a review from MasterEvarior January 16, 2025 12:52

MasterEvarior requested changes Jan 16, 2025

View reviewed changes

ManuelMoeri and others added 20 commits January 16, 2025 15:34

Refactor duplicating methods to include values of keyResult

68d057b

Modify duplicateObjectiveDto to only include ids

7407955

fix actionlist shared refrence error

667eb41

fix action being asigned to the wrong action

de7820f

run formatter

0b69b85

fix duplicate tests

39d7d44

make new method to duplicate Actionlists

8761c7c

make shouldDupllicateActionList check if every attribute was copied e…

56d64ff

…xcept id

fix duplicate keyresult tests

02ebb53

run formatter

0581fa8

write new e2e test testing if all keyresult attributes get duplicated

7da0700

fix duplicate so you can choose which key results you wanna duplicate

f337afb

remove not needed commented line

c4ef623

remove id out of pathvariable for duplicate

b71dcb9

run formatter

290459f

fix id still being passed as a param in objective form

bcd75a0

fix duplicateObjective mapping

b51f091

remove unused import

2b99de1

remove outdated comment

dfb9714

revert formatter changes

e5de435

nevio18324 and others added 18 commits January 16, 2025 15:34

remove unnecessary wait

6e04718

remove action list attribute

f915735

Finish logic of duplicating objectives with the action plan

a4071d3

Delete unused test, add two new ones and apply formatters

54ea73c

Fix tests and enhance logic

67a586d

Format code

c1afcff

Resolve conversations

d9ce1a1

remove any from Objective controller duplicate test

1cb243f

refactor shouldDuplicateMetricKeyResult test

aa034c5

Continue refactoring of logic and fix a couple of tests

554ba39

Fix last backend test

b406d97

Add test for ordinal keyResult as well

2420339

Remove it.only in cypress tests

9f6842d

Enhance naming of param

12b8a05

Co-authored-by: MasterEvarior <[email protected]>

Make naming of KeyResultId param more clear

7573ec8

Co-authored-by: MasterEvarior <[email protected]>

Replace else if with switch statement

95b113b

Co-authored-by: MasterEvarior <[email protected]>

Make test paramaterized to check for empty and null

fe7c39f

Format code

f153414

ManuelMoeri force-pushed the bug/1255-duplicating-of-objective-should-bring-all-properties branch from 4ab547d to f153414 Compare January 16, 2025 14:34

MasterEvarior reviewed Jan 17, 2025

View reviewed changes

backend/src/test/java/ch/puzzle/okr/service/business/ActionBusinessServiceTest.java Outdated Show resolved Hide resolved

Improve parameterized test name

69a988c

MasterEvarior approved these changes Jan 17, 2025

View reviewed changes

MasterEvarior merged commit cf41b47 into main Jan 17, 2025
18 checks passed

MasterEvarior deleted the bug/1255-duplicating-of-objective-should-bring-all-properties branch January 17, 2025 06:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug/1255 Duplicating a objective does not bring all properties of the KeyResults #1294

Bug/1255 Duplicating a objective does not bring all properties of the KeyResults #1294

ManuelMoeri commented Jan 13, 2025

MasterEvarior left a comment

MasterEvarior left a comment

Bug/1255 Duplicating a objective does not bring all properties of the KeyResults #1294

Bug/1255 Duplicating a objective does not bring all properties of the KeyResults #1294

Conversation

ManuelMoeri commented Jan 13, 2025

MasterEvarior left a comment

Choose a reason for hiding this comment

MasterEvarior left a comment

Choose a reason for hiding this comment