Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/306 check in erfassen und bearbeiten #427

Merged
merged 97 commits into from
Oct 4, 2023
Merged

Feature/306 check in erfassen und bearbeiten #427

merged 97 commits into from
Oct 4, 2023

Conversation

Vakmeth
Copy link
Collaborator

@Vakmeth Vakmeth commented Sep 26, 2023 •
edited
Loading

Was gemacht wurde:

  • Dialog zur Erstellung eines Check-ins implementiert
  • Edit & Delete Optionen in der Check-in history eingebaut
  • Datenbankfixtures updated
  • Confirmdialog eingebaut
  • Eigener input Komponent erstellt mit nötiger höhe welche vom Figma vorgegeben wurde

@Vakmeth Vakmeth force-pushed the feature/306-check-in-erfassen-und-bearbeiten branch from 1d7db10 to 4ece9e1 Compare September 29, 2023 06:27
@Vakmeth Vakmeth requested a review from tuxmatta October 2, 2023 14:04
@Vakmeth Vakmeth requested a review from tuxmatta October 3, 2023 14:14
@Vakmeth Vakmeth force-pushed the feature/306-check-in-erfassen-und-bearbeiten branch from d209818 to f7899df Compare October 4, 2023 07:47
Vakmeth added 25 commits October 4, 2023 10:09
@Vakmeth
generate check in dialog
9473029
@Vakmeth
format generated dialog
5793787
@Vakmeth
implement structure
7091427
@Vakmeth
change width of dialog and implement formgroup and corresponding meth…
435f5f3 
…ods of example-dialog
@Vakmeth
change size of textarea to match figma
6075fd7
@Vakmeth
align content by adding all elements inside mat-dialog-content tag
1d0745c
@Vakmeth
finish basic structure of metric and ordinal check-in
f16b475
@Vakmeth
rename component because we have to implement a different dialog for …
048de70 
…each type of check-in
@Vakmeth
implement and align metric components of dialog
080b7cd
@Vakmeth
restyle confidence component and add margin to match figma mockup
8fb88db
@Vakmeth
increase width of slider and delete console log
3c019d3
@Vakmeth
implement correct formating of default value with custom pipe
a86ff5a
@Vakmeth
format pipe file
842f11c
@Vakmeth
implement formgroup with validators and add form control names in tem…
5ba1670 
…plate
@Vakmeth
fix button position by wrapping buttons into custom flexed div
ff63a2f
@Vakmeth
set confidence value from confidence component after clicked on submi…
a6e174a 
…t button
@Vakmeth
implement method to update value with correct label whenever focues o…
eeced45 
…ut of input
@Vakmeth
add parseValue function to be able to return value in save method
9df627a
@Vakmeth
implement workflow of creating checkIn in frontend
16cfc49
@Vakmeth
fix error of missing keyResultId in checkIn
a14d3d6
@Vakmeth
update keyResultDetail after creating new checkIn and rename method o…
b7da170 
…f service to match its use
@Vakmeth
add option to differ between ordinal and metric checkIn dialog
1a27a0e
@Vakmeth
add check to do create request only if created form data is not undef…
2f6bfe1 
…ined
@Vakmeth
format error message of input field
47ae5d0
@Vakmeth
create check-in-form-ordinal component and let detail of keyresult op…
27f9e95 
…en it if keyresult is ordinal
@Vakmeth Vakmeth force-pushed the feature/306-check-in-erfassen-und-bearbeiten branch from b74b957 to 10355fb Compare October 4, 2023 08:09
@Vakmeth Vakmeth marked this pull request as ready for review October 4, 2023 08:12
tuxmatta
tuxmatta requested changes Oct 4, 2023
View reviewed changes
...hared/dialog/checkin/check-in-base-informations/check-in-base-informations.component.spec.ts Outdated Show resolved Hide resolved
frontend/src/app/shared/dialog/checkin/check-in-form-ordinal/check-in-form-ordinal.component.ts Outdated Show resolved Hide resolved
frontend/src/app/shared/dialog/checkin/check-in-form-metric/check-in-form-metric.component.ts Outdated Show resolved Hide resolved
frontend/src/app/shared/dialog/checkin/check-in-form-metric/check-in-form-metric.component.ts Outdated Show resolved Hide resolved
frontend/src/app/shared/pipes/unit-value-transformation/unit-transformation.pipe.spec.ts Show resolved Hide resolved
frontend/src/app/shared/pipes/unit-label-transformation/unit-label-transformation.pipe.spec.ts Show resolved Hide resolved
@Vakmeth Vakmeth requested a review from tuxmatta October 4, 2023 13:25
@tuxmatta tuxmatta merged commit 6a4f2d9 into main Oct 4, 2023
4 checks passed
@Miguel7373 Miguel7373 deleted the feature/306-check-in-erfassen-und-bearbeiten branch October 31, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxmatta tuxmatta tuxmatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vakmeth @tuxmatta