Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/306 check in refactoring #466

Merged
merged 22 commits into from
Oct 19, 2023
Merged

Conversation

Vakmeth
Copy link
Collaborator

@Vakmeth Vakmeth commented Oct 13, 2023

Was gemacht wurde:

  • View des Check-in forms überarbeitet
  • View der Check-in History überarbeitet
  • Pipe zur Darstellung des Werts eines Check-ins überarbeitet (nun werden Tausender Zeichen (') und negative Werte auch in der Formatierung miteinbezogen)
  • Delete für Check-ins wurde im Frontend komplett ausgebaut, der Backend Endpoint bleibt bestehen, falls fachlich neue Anforderungen auftauchen, welche nach diesem Endpoint verlangen.

=> Die Endimplementation vor Review am 18.12.2023 wurde mit UX besprochen, @tobiasstern hat als Feedback das Erhöhen der Margin im Check-In History Dialog zwischen Label und Text angegeben, dieses Feedback wurde umgesetzt.

@Vakmeth Vakmeth force-pushed the feature/306-check-in-refactoring branch 2 times, most recently from d3c15c3 to 394170c Compare October 18, 2023 08:07
@Vakmeth Vakmeth force-pushed the feature/306-check-in-refactoring branch from 394170c to cb170a5 Compare October 18, 2023 08:08
@Vakmeth Vakmeth marked this pull request as ready for review October 18, 2023 08:11
@Vakmeth Vakmeth requested a review from peggimann October 18, 2023 08:11
@Vakmeth Vakmeth self-assigned this Oct 18, 2023
@peggimann peggimann merged commit be5783d into main Oct 19, 2023
4 checks passed
@Miguel7373 Miguel7373 deleted the feature/306-check-in-refactoring branch October 31, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants