Feature/552 e2e scoring

.run/OkrApplication-Dev.run.xml

@@ -1,7 +1,7 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="OkrApplication-Dev" type="SpringBootApplicationConfigurationType" factoryName="Spring Boot">
     <option name="ACTIVE_PROFILES" value="dev" />
-    <option name="ALTERNATIVE_JRE_PATH" value="azul-17" />
+    <option name="ALTERNATIVE_JRE_PATH" value="17" />
     <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="true" />
     <module name="backend" />
     <option name="SPRING_BOOT_MAIN_CLASS" value="ch.puzzle.okr.OkrApplication" />

.run/OkrApplication-E2E.run.xml

@@ -1,7 +1,7 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="OkrApplication-E2E" type="SpringBootApplicationConfigurationType" factoryName="Spring Boot">
     <option name="ACTIVE_PROFILES" value="integration-test" />
-    <option name="ALTERNATIVE_JRE_PATH" value="azul-17" />
+    <option name="ALTERNATIVE_JRE_PATH" value="17" />
     <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="true" />
     <module name="backend" />
     <option name="SPRING_BOOT_MAIN_CLASS" value="ch.puzzle.okr.OkrApplication" />

frontend/cypress.config.ts

@@ -3,6 +3,7 @@ import { defineConfig } from 'cypress';
 export default defineConfig({
   e2e: {
     baseUrl: 'http://localhost:4200',
+    experimentalMemoryManagement: true,
   },
   env: {
     login_url: 'https://idp-mock-okr.ocp-internal.cloudscale.puzzle.ch',

frontend/cypress/e2e/checkIn.cy.ts

@@ -143,7 +143,6 @@ describe('OKR Check-in e2e tests', () => {
     it('Edit metric checkin', () => {
       cy.getByTestId('objective').first().getByTestId('add-keyResult').first().click();
       cy.getByTestId('submit').should('be.disabled');
-
       cy.fillOutKeyResult(
         'Here we edit a metric checkin',
         'CHF',
@@ -155,6 +154,7 @@ describe('OKR Check-in e2e tests', () => {
         null,
         'This is my description',
       );
+
       cy.getByTestId('submit').click();
 
       cy.getByTestId('keyresult').contains('Here we edit a metric checkin').click();
@@ -166,7 +166,7 @@ describe('OKR Check-in e2e tests', () => {
 
       cy.wait(500);
       cy.contains('Check-in History');
-      cy.getByTestId('edit-check-in').click();
+      cy.getByTestId('edit-check-in').first().click();
       cy.contains('Here we edit a metric checkin');
       cy.contains('CHF 30.-');
       cy.contains('Confidence um Target (CHF 213.-) zu erreichen');
@@ -211,11 +211,11 @@ describe('OKR Check-in e2e tests', () => {
 
       cy.wait(500);
       cy.contains('Check-in History');
-      cy.getByTestId('edit-check-in').click();
+      cy.getByTestId('edit-check-in').first().click();
       cy.contains('For editing ordinal checkin');
       cy.contains('Confidence um Target zu erreichen');
       cy.contains('6/10');
-      cy.getByTestId('stretchZone').click();
+      cy.getByTestId('stretch-radio').click();
       cy.getByTestId('confidence-slider').realMouseDown();
       cy.getByTestId('check-in-next').click();
       cy.contains('There is a new car');

frontend/cypress/e2e/keyresult.cy.ts

@@ -7,25 +7,7 @@ describe('OKR Overview', () => {
   });
 
   it('Create new metric KeyResult', () => {
-    cy.getByTestId('objective').first().getByTestId('add-keyResult').first().click();
-    cy.getByTestId('submit').should('be.disabled');
-    cy.contains('Key Result erfassen');
-    cy.contains('Jaya Norris');
-    checkForDialogText();
-
-    cy.fillOutKeyResult(
-      'I am a metric keyresult',
-      'PERCENT',
-      '21',
-      '52',
-      null,
-      null,
-      null,
-      'Pac',
-      'This is my description',
-    );
-    cy.getByTestId('submit').should('not.be.disabled');
-    cy.getByTestId('submit').click();
+    cy.createMetricKeyresult(null, null, null);
 
     cy.getByTestId('keyresult').contains('I am a metric keyresult').click();
 
@@ -43,7 +25,7 @@ describe('OKR Overview', () => {
   });
 
   it('Create new ordinal KeyResult', () => {
-    createOrdinalKeyResult(null, 'Pac');
+    cy.createOrdinalKeyresult(null, 'Pac');
 
     cy.getByTestId('keyresult').contains('I am a ordinal keyresult').click();
     cy.contains('I am a ordinal keyresult');
@@ -68,7 +50,7 @@ describe('OKR Overview', () => {
     cy.getByTestId('submit').should('be.disabled');
     cy.contains('Key Result erfassen');
     cy.contains('Jaya Norris');
-    checkForDialogText();
+    cy.checkForDialogText();
 
     cy.fillOutKeyResult(
       'I am a metric keyresult with a new one',
@@ -87,7 +69,7 @@ describe('OKR Overview', () => {
     cy.getByTestId('submit').should('be.disabled');
     cy.contains('Key Result erfassen');
     cy.contains('Jaya Norris');
-    checkForDialogText();
+    cy.checkForDialogText();
   });
 
   it('Create and edit KeyResult with Action Plan', () => {
@@ -139,7 +121,7 @@ describe('OKR Overview', () => {
   });
 
   it('Edit a KeyResult without type change', () => {
-    createOrdinalKeyResult('We want not to change keyresult title');
+    cy.createOrdinalKeyresult('We want not to change keyresult title', null);
 
     cy.getByTestId('keyresult').contains('We want not to change keyresult title').last().click();
     cy.getByTestId('edit-keyResult').click();
@@ -176,7 +158,7 @@ describe('OKR Overview', () => {
   });
 
   it('Edit a KeyResult with type change', () => {
-    createOrdinalKeyResult('Here we want to change keyresult title');
+    cy.createOrdinalKeyresult('Here we want to change keyresult title', null);
 
     cy.getByTestId('keyresult').contains('Here we want to change keyresult title').last().click();
     cy.getByTestId('edit-keyResult').click();
@@ -220,7 +202,7 @@ describe('OKR Overview', () => {
     cy.getByTestId('objective').first().getByTestId('add-keyResult').first().click();
     cy.getByTestId('submit').should('be.disabled');
     cy.contains('Key Result erfassen');
-    checkForDialogText();
+    cy.checkForDialogText();
 
     cy.fillOutKeyResult(
       'I am a metric keyresult',
@@ -304,7 +286,7 @@ describe('OKR Overview', () => {
   });
 
   it('Delete existing keyresult', () => {
-    createOrdinalKeyResult('A keyresult to delete');
+    cy.createOrdinalKeyresult('A keyresult to delete', null);
 
     cy.getByTestId('keyresult').contains('A keyresult to delete').last().click();
 
@@ -317,44 +299,3 @@ describe('OKR Overview', () => {
     cy.get('A keyresult to delete').should('not.exist');
   });
 });
-
-function createOrdinalKeyResult(title: string | null = null, owner: string | null = null) {
-  cy.getByTestId('objective').first().getByTestId('add-keyResult').first().click();
-  cy.getByTestId('submit').should('be.disabled');
-  cy.contains('Key Result erfassen');
-  cy.contains('Jaya Norris');
-  checkForDialogText();
-  cy.getByTestId('titleInput').type('Title');
-
-  cy.getByTestId('ordinalTab').click();
-
-  cy.fillOutKeyResult(
-    title == null ? 'I am a ordinal keyresult' : title,
-    null,
-    null,
-    null,
-    'My commit zone',
-    'My target zone',
-    'My stretch zone',
-    owner,
-    'This is my description',
-  );
-
-  cy.getByTestId('submit').should('not.be.disabled');
-  cy.getByTestId('submit').click();
-}
-
-function checkForDialogText() {
-  cy.contains('Titel');
-  cy.contains('Metrisch');
-  cy.contains('Ordinal');
-  cy.contains('Einheit');
-  cy.contains('Baseline');
-  cy.contains('Stretch Goal');
-  cy.contains('Owner');
-  cy.contains('Beschreibung (optional)');
-  cy.contains('Action Plan (optional)');
-  cy.contains('Weitere Action hinzufügen');
-  cy.contains('Speichern');
-  cy.contains('Abbrechen');
-}

frontend/cypress/e2e/scoring.cy.ts

@@ -0,0 +1,54 @@
+import * as users from '../fixtures/users.json';
+import { getPercentageMetric, getPercentageOrdinal } from 'cypress/support/scoringSupport';
+import { onlyOn } from '@cypress/skip-test';
+
+describe('Scoring component e2e tests', () => {
+  beforeEach(() => {
+    cy.loginAsUser(users.gl);
+    onlyOn('chrome');
+    cy.visit('/?quarter=2');
+  });
+
+  [
+    [0, 100, 10],
+    [0, 100, 31],
+    [0, 100, 71],
+    [0, 100, 100],
+  ].forEach(([baseline, stretchgoal, value]) => {
+    it('Create metric checkin and validate value of scoring component', () => {
+      cy.createMetricKeyresult('Metric scoring keyresult', String(baseline), String(stretchgoal));
+      cy.getByTestId('keyresult').get(':contains("Metric scoring keyresult")').last().click();
+      cy.getByTestId('add-check-in').click();
+      cy.getByTestId('key-result-metric-value').clear().type(String(value));
+      cy.getByTestId('confidence-slider').click();
+      cy.realPress('{rightarrow}').realPress('{rightarrow}').realPress('{rightarrow}');
+      cy.getByTestId('check-in-next').click();
+      cy.getByTestId('changeInfo').click().type('Testveränderungen');
+      cy.getByTestId('initiatives').click().type('Testmassnahmen');
+      cy.getByTestId('create-checkin').click();
+      const percentage = getPercentageMetric(baseline, stretchgoal, value);
+      cy.validateScoring(false, percentage);
+      cy.getByTestId('close-drawer').click();
+      cy.validateScoring(true, percentage);
+    });
+  });
+
+  [['fail'], ['commit'], ['target'], ['stretch']].forEach(([zoneName]) => {
+    it('Create ordinal checkin and validate value of scoring component', () => {
+      cy.createOrdinalKeyresult('Ordinal scoring keyresult', null);
+      cy.getByTestId('keyresult').get(':contains("Ordinal scoring keyresult")').last().click();
+      cy.getByTestId('add-check-in').click();
+      cy.getByTestId(`${zoneName}-radio`).click();
+      cy.getByTestId('confidence-slider').click();
+      cy.realPress('{rightarrow}').realPress('{rightarrow}').realPress('{rightarrow}');
+      cy.getByTestId('check-in-next').click();
+      cy.getByTestId('changeInfo').click().type('Testveränderungen');
+      cy.getByTestId('initiatives').click().type('Testmassnahmen');
+      cy.getByTestId('create-checkin').click();
+      const percentage = getPercentageOrdinal(zoneName);
+      cy.validateScoring(false, percentage);
+      cy.getByTestId('close-drawer').click();
+      cy.validateScoring(true, percentage);
+    });
+  });
+});

frontend/cypress/support/commands.ts

@@ -1,3 +1,5 @@
+import { validateScoring } from './scoringSupport';
+
 Cypress.Commands.add('loginAsUser', (user: any) => {
   loginWithCredentials(user.username, user.password);
   overviewIsLoaded();
@@ -10,6 +12,14 @@ Cypress.Commands.add('getByTestId', { prevSubject: 'optional' }, (subject: any,
   return cy.get(`[data-testId=${testId}]`);
 });
 
+Cypress.Commands.add('getZone', (zone: string, onOverview: boolean) => {
+  return (onOverview ? cy.focused() : cy.getByTestId('side-panel')).getByTestId(zone);
+});
+
+Cypress.Commands.add('validateScoring', (isOverview: boolean, percentage: number) => {
+  validateScoring(isOverview, percentage);
+});
+
 Cypress.Commands.add(
   'fillOutObjective',
   (
@@ -60,16 +70,16 @@ Cypress.Commands.add(
   ) => {
     switch (currentZoneIndex) {
       case 0:
-        cy.getByTestId('failZone').click();
+        cy.getByTestId('fail-radio').click();
         break;
       case 1:
-        cy.getByTestId('commitZone').click();
+        cy.getByTestId('commit-radio').click();
         break;
       case 2:
-        cy.getByTestId('targetZone').click();
+        cy.getByTestId('target-radio').click();
         break;
       case 3:
-        cy.getByTestId('stretchZone').click();
+        cy.getByTestId('stretch-radio').click();
         break;
     }
     changeConfidence(shouldChangeConfidence);
@@ -100,6 +110,82 @@ Cypress.Commands.add('tabBackwardUntil', (selector: string, limit?: number) => {
   doUntil(selector, cy.tabBackward, limit);
 });
 
+Cypress.Commands.add('createOrdinalKeyresult', (title: string | null = null, owner: string | null = null) => {
+  cy.getByTestId('objective').first().getByTestId('add-keyResult').first().click();
+  cy.getByTestId('submit').should('be.disabled');
+  cy.contains('Key Result erfassen');
+  cy.contains('Jaya Norris');
+  cy.contains('Titel');
+  cy.getByTestId('titleInput').type('Title');
+  cy.getByTestId('ordinalTab').click();
+  cy.contains('Metrisch');
+  cy.contains('Ordinal');
+  cy.contains('Commit Zone');
+  cy.contains('Target Zone');
+  cy.contains('Stretch Zone');
+  cy.contains('Owner');
+  cy.contains('Beschreibung (optional)');
+  cy.contains('Action Plan (optional)');
+  cy.contains('Weitere Action hinzufügen');
+  cy.contains('Speichern');
+  cy.contains('Abbrechen');
+
+  cy.fillOutKeyResult(
+    title == null ? 'I am a ordinal keyresult' : title,
+    null,
+    null,
+    null,
+    'My commit zone',
+    'My target zone',
+    'My stretch zone',
+    owner,
+    'This is my description',
+  );
+
+  cy.getByTestId('submit').should('not.be.disabled');
+  cy.getByTestId('submit').click();
+});
+
+Cypress.Commands.add(
+  'createMetricKeyresult',
+  (title: string | null, baseline: string | null, stretchGoal: string | null) => {
+    cy.getByTestId('objective').first().getByTestId('add-keyResult').first().click();
+    cy.getByTestId('submit').should('be.disabled');
+    cy.contains('Key Result erfassen');
+    cy.contains('Jaya Norris');
+    cy.checkForDialogText();
+
+    cy.fillOutKeyResult(
+      title == null ? 'I am a metric keyresult' : title,
+      'PERCENT',
+      baseline === null ? '21' : baseline,
+      stretchGoal === null ? '52' : stretchGoal,
+      null,
+      null,
+      null,
+      'Pac',
+      'This is my description',
+    );
+    cy.getByTestId('submit').should('not.be.disabled');
+    cy.getByTestId('submit').click();
+  },
+);
+
+Cypress.Commands.add('checkForDialogText', () => {
+  cy.contains('Titel');
+  cy.contains('Metrisch');
+  cy.contains('Ordinal');
+  cy.contains('Einheit');
+  cy.contains('Baseline');
+  cy.contains('Stretch Goal');
+  cy.contains('Owner');
+  cy.contains('Beschreibung (optional)');
+  cy.contains('Action Plan (optional)');
+  cy.contains('Weitere Action hinzufügen');
+  cy.contains('Speichern');
+  cy.contains('Abbrechen');
+});
+
 Cypress.Commands.add(
   'fillOutKeyResult',
   (

frontend/cypress/support/component.ts

@@ -9,6 +9,11 @@ declare global {
       tabBackward(): void;
       tabForwardUntil(selector: string, limit?: number): void;
       tabBackwardUntil(selector: string, limit?: number): void;
+      createOrdinalKeyresult(title: string | null, owner: string | null): void;
+      createMetricKeyresult(title: string | null, baseline: string | null, stretchGoal: string | null): void;
+      getZone(zone: string, onOverview: boolean): Chainable;
+      validateScoring(isOverview: boolean, percentage: number): Chainable;
+      checkForDialogText(): void;
       fillOutObjective(
         objectiveTitle: string,
         button: string,