Feature/943 tenant via iss #946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in h2 db schema. Improve team-management cypress tests
…n in h2 db schema. Improve team-management cypress tests
… first entry. Fix Unit tests, add Cypress tests.
… 704_benutzerverwaltung # Conflicts: # frontend/src/app/team-management/team-management.component.spec.ts
+ fix: some cypress tests + fix: authorization user cache + fix: edit team visibility + fix: user should be allowed to delete membership of any team + fix: when deleting a team, users should be reloaded
# Conflicts: # backend/src/test/java/ch/puzzle/okr/controller/OverviewControllerIT.java # frontend/src/app/components/objective/objective.component.spec.ts # frontend/src/assets/i18n/de.json
+ fix overview query to load overviews for okr champion correctly + fix team pipe to show correct number of teams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Es gibt neu ein File
realm-export-pitc-without-tenant.json, das ein Keycloak export ist mit Tenantpitc, wobei kein Claim Mapper für pitc vorhanden ist. Daher wird das JWT Token auch keinen 'tenant' Claim enthalten. Dies ist nützlich fürs Testing. OKR sollte mit diesem Keycloak Export immer noch funktionieren.PS: es ist der Original realm-export-pitc.json Export, aber ohne Tenant PITC claim mapper. Tenant
acmeist auch enthalten inkl. Tenant ACME claim mapper.Das Mapping in
JwtHelper.javaist so implementiert, dass zuerst versucht wird, das mapping via iss Claim zu machen. Falls das nicht funktioniert, wird als Fallback ein Mapping via tenant Claim versucht. Weitere Fallbacks können einfach hinzugefügt werden. Denkbar wäre, dass ev. bei einem Tenant XY die iss URL nicht so aussieht, wie erwartet.Es wird geloggt, welche Strategie für die Tenant Bestimmung verwendet wird und ob sie erfolgreich ist. Dies ist v.a. fürs Testing nützlich.