Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/958 fix h2 quarters and tests #979

Merged
merged 38 commits into from
Aug 14, 2024
Merged

Feature/958 fix h2 quarters and tests #979

merged 38 commits into from
Aug 14, 2024

Conversation

clean-coder
Copy link
Collaborator

Eine Analyse hat ergeben, dass man nur wenige Quarters braucht. Man braucht, damit die Tests laufen:

  • ein aktuelles Quarter mit fixer DB Id 2
  • ein next Quarter mit fixer DB Id 3
  • ein Quarter Backlog mit fixer DB Id 999
  • und ein zusätzliches Quarter GJ ForTests mit fixer DB Id 99

Die Cypress und Integration Tests sind nun so angepasst, dass sie mit diesen 4 Quarters funktionieren. Wichtig ist dabei:

  • Backlog und GJ ForTests sind fix (bzgl. Label und Id). In den Tests kann auf das Label und die Id zugegriffen werden
  • beim aktuellen und next Quarter ist dies anders: die Ids sind und müssen fix bleiben und man kann in den Tests auf diese Id zugreifen. Das Label (+ startDate/EndDate) werden sich alle 3 Monate ändern. Daher darf kein Test auf das Label zugreifen. Falls ein Test auf ein Label zugreifen muss, dann einfach das GJ ForTests Quarter verwenden.

Im File V100_0_0__TestData.sql wird die H2 DB mit Testdaten gefüllt. Dazu gehören auch die Quarters. Backlog und GJ ForTests haben fixe Werte. Aktuelles und next Quarter werden neu immer berechnet (zum aktuellen) Datum. Daher sollte nun auch H2 immer aktuelle Quarters haben.

clean-coder added 30 commits July 12, 2024 10:39
@clean-coder
#958: only 4 Quarters in h2: current + next Quarter, Backlog and "GJ …
031f17f 
…ForTests"
@clean-coder
#958: fix IT Tests für Anpassung der Quartale
2674daf
@clean-coder
#958: fix Cypress Tests für Anpassung der Quartale
3c849ba
@clean-coder
#958: quarter sql string generator
fba7e8c
@clean-coder
#958: cleanup QuarterSqlGeneratorTest
41c3780
@clean-coder
#958: remove unused classes
1dd5317
@clean-coder
#958: rename QuarterSqlGenerator.java to Quarters
90d8e2f
@clean-coder
#958: refactoring - GJ uses Quarters functionality
65ac130
@clean-coder
#958: refactoring - cleanup
b32a5cb
@clean-coder
#958: refactoring - currentQuarter() returns QuarterDataWithGJ
694ae71
@clean-coder
#958: refactoring - GJ has no external dependencies (expect now)
4067dae
@clean-coder
#958: start implementing h2 Function class
b3b496a
@clean-coder
#958: refactoring - remove quarterDigit from QuarterData
4da2ccc
@clean-coder
#958: refactoring (in Quarters: year for constructor, now for current…
088bf1d 
…Quarter) + cleanup
@clean-coder
#958: refactoring - rename QuarterDataWithGJ to QuarterData
a2aac1f
@clean-coder
#958: refactoring - create package util.quarter.generate
3585a97
@clean-coder
#958: refactoring - rename GJ to QuarterLabel
946319b
@clean-coder
#958: added test for QuarterFunction
06c86fc
@clean-coder
#958: cleanup test
ba67637
@clean-coder
#958: refactoring - rename to currentQuarter()
d83db58
@clean-coder
#958: refactoring - throw exception if currentQuarter() founds no mat…
a22c629 
…ching quarter
@clean-coder
#958: cleanup - improve test method names
8c01b55
@clean-coder
#958: additional test for boundary dates
9ccf4a4
@clean-coder
#958: cleanup - make helper methods private
73e519b
@clean-coder
#958: cleanup - remove "test" main method
26fb3be
@clean-coder
#958: h2 immer aktuelle Quarter generieren (via Java)
f70dc58
@clean-coder
#958: cleanup
a36e46d
@clean-coder
#958: cleanup
b0c02d4
@clean-coder
#958: cleanup QuarterData
f768635
@clean-coder
#958: cleanup QuartersTest
3160deb
@pizzi-cato pizzi-cato force-pushed the feature/958_fix_h2_quarters_and_tests branch 2 times, most recently from ff25e05 to 8038cc4 Compare August 14, 2024 07:18
@pizzi-cato pizzi-cato self-requested a review August 14, 2024 07:20
pizzi-cato
pizzi-cato previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@pizzi-cato pizzi-cato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. document quarter utils to be NOT used in production mode
  2. ignore app/src/version.ts created by prod build

@pizzi-cato pizzi-cato force-pushed the feature/958_fix_h2_quarters_and_tests branch from 8038cc4 to 58a95b4 Compare August 14, 2024 12:27
@pizzi-cato pizzi-cato merged commit 39e63aa into main Aug 14, 2024
5 checks passed
@MasterEvarior MasterEvarior deleted the feature/958_fix_h2_quarters_and_tests branch October 31, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pizzi-cato pizzi-cato pizzi-cato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clean-coder @pizzi-cato