Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling options for links #53

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Styling options for links #53

merged 2 commits into from
Nov 1, 2024

Conversation

rogancodes
Copy link
Contributor

@rogancodes rogancodes commented Oct 3, 2024 •
edited
Loading

Addresses issue #10

Its my first pull request. Let me know if any changes required.

@rogancodes rogancodes marked this pull request as ready for review October 3, 2024 11:20
codez
codez requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@codez codez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR. It looks fine and I found just a few small adjustments.

Sorry to answer so late, I lost track of it during my vacation.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/prawn/markup/processor/text.rb Outdated Show resolved Hide resolved
lib/prawn/markup/processor/text.rb Outdated Show resolved Hide resolved
spec/prawn/markup/showcase_spec.rb Outdated Show resolved Hide resolved
@rogancodes rogancodes requested a review from codez November 1, 2024 03:18
@rogancodes
Copy link
Contributor Author

Please verify if the test case is appropriate. If not, could you suggest an alternative approach to assert the changes?

codez
codez approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@codez codez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your work

@codez codez merged commit 1279dd4 into puzzle:main Nov 1, 2024
6 checks passed
@codez codez mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codez codez codez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rogancodes @codez