improove OPNsenseConfig errorhandling #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if an exception is occurring during a module execution within the context of a
OPNsenseConfig
object, python calls__exit__
which results in a misleading error messageConfig has changed. Cannot exit without saving.
.If for example we try to update the config by modifying it but we did not specify
become: true
we get the following error message:By first checking the exception type, we can make sure there was no exception and then proceed with the check for a changed config. If there was an exception, we will return it's type and value: