Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add_version_aware_methods #32

Merged
merged 23 commits into from
Dec 7, 2023
Merged

Feature/add_version_aware_methods #32

merged 23 commits into from
Dec 7, 2023

Conversation

KiLLuuuhh
Copy link
Contributor

Adds various features:

  • added version aware module settings methods like get_module_setting(), apply_module_setting(), del_module_setting() and set_module_setting()
  • added multiple helper functions
  • added multiple unit tests to improve test coverage

@KiLLuuuhh KiLLuuuhh self-assigned this Nov 9, 2023
@KiLLuuuhh KiLLuuuhh changed the title Feature/add config manager Feature/add_version_specific_methods Nov 9, 2023
@KiLLuuuhh KiLLuuuhh changed the title Feature/add_version_specific_methods Feature/add_version_aware_methods Nov 9, 2023
rekup
rekup reviewed Nov 18, 2023
View reviewed changes
plugins/module_utils/config_utils.py Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Show resolved Hide resolved
plugins/module_utils/config_utils.py Show resolved Hide resolved
plugins/module_utils/version_utils.py Outdated Show resolved Hide resolved
DonGiovanni83
DonGiovanni83 requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@DonGiovanni83 DonGiovanni83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few 'cosmetic' requests. Besides them it looks good 👍🏼

plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/config_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/version_utils.py Outdated Show resolved Hide resolved
tests/unit/plugins/module_utils/test_config_utils.py Show resolved Hide resolved
KiLLuuuhh and others added 7 commits December 3, 2023 11:02
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/config_utils.py
7f71909 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/config_utils.py
f787c75 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/config_utils.py
ed6d21e 
Co-authored-by: Fabio Bertagna <[email protected]>
@KiLLuuuhh @DonGiovanni83
Update plugins/module_utils/version_utils.py
33a0055 
Co-authored-by: Fabio Bertagna <[email protected]>
applied dongoviannis suggestions in https://github.com/puzzle/puzzle.…
bccebb7 
…opnsense/pull/32\#discussion_r1409448425
applied dongoviannis suggestions in https://github.com/puzzle/puzzle.…
247158d 
…opnsense/pull/32\#discussion_r1409451170
applied dongoviannis suggestions in https://github.com/puzzle/puzzle.…
3bb3e4f 
…opnsense/pull/32\#discussion_r1409452245
DonGiovanni83
DonGiovanni83 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@DonGiovanni83 DonGiovanni83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@KiLLuuuhh KiLLuuuhh merged commit 781f10e into puzzle:main Dec 7, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekup rekup rekup left review comments

@DonGiovanni83 DonGiovanni83 DonGiovanni83 approved these changes

Assignees

@KiLLuuuhh KiLLuuuhh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KiLLuuuhh @DonGiovanni83 @rekup