update rubocop config, fix rubocop issues

.rubocop-must.yml

@@ -0,0 +1,35 @@
+# Rubocop configuration that MUST hold for every build.
+
+AllCops:
+  DisplayCopNames: true
+  DisabledByDefault: true
+  Exclude:
+    - Rakefile
+    - db/**/*
+    - config/**/*
+    - bin/**/*
+    - spec/**/*
+    - vendor/**/*
+    - tmp/**/*
+    - frontend/**/*
+
+Metrics/AbcSize:
+  Max: 17
+
+Metrics/ClassLength:
+  Max: 200
+
+Metrics/CyclomaticComplexity:
+  Max: 6
+
+Metrics/LineLength:
+  Max: 100
+
+Metrics/MethodLength:
+  Max: 10
+
+Metrics/ModuleLength:
+  Max: 200
+
+Metrics/ParameterLists:
+  Max: 4

Gemfile

@@ -1,28 +1,26 @@
-# encoding: utf-8
-
 source 'https://rubygems.org'
 
 gem 'rails', '5.1.4'
 
 gem 'active_model_serializers', '~> 0.10.6'
 gem 'activerecord-postgresql-adapter'
+gem 'airbrake', '~> 5.0'
 gem 'annotate'
 gem 'carrierwave'
+gem 'database_cleaner'
+gem 'deep_cloneable', '~> 2.2.2'
 gem 'faker'
-gem 'odf-report'
 gem 'mini_magick'
 gem 'mysql2'
 gem 'net-ldap', '~> 0.14.0'
+gem 'odf-report'
 gem 'pg', '0.19.0.pre20160409114042'
 gem 'pg_search'
 gem 'puma', '~> 3.0'
 gem 'rack'
 gem 'rails-i18n', '~> 5.0.4'
 gem 'seed-fu', '~> 2.3.7'
 gem 'sqlite3'
-gem 'deep_cloneable', '~> 2.2.2'
-gem 'airbrake', '~> 5.0'
-gem 'database_cleaner'
 
 group :metrics do
   gem 'brakeman'
@@ -51,4 +49,4 @@ group :test do
   gem 'simplecov', '~> 0.12.0'
 end
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
-gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
+gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw jruby]

Rakefile

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
@@ -10,7 +8,7 @@ require 'rake/testtask'
 Rails.application.load_tasks
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << %w(lib test)
+  t.libs << %w[lib test]
   t.test_files = Dir['test/**/*_test.rb'].reject do |path|
     path.include?('features')
   end

app/channels/application_cable/channel.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 module ApplicationCable
   class Channel < ActionCable::Channel::Base
   end

app/channels/application_cable/connection.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 module ApplicationCable
   class Connection < ActionCable::Connection::Base
   end

app/controllers/activities_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 class ActivitiesController < PersonRelationsController
-  self.permitted_attrs = [:description, :role, :technology, :year_from, :year_to, :person_id]
+  self.permitted_attrs = %i[description role technology year_from year_to person_id]
 end

app/controllers/advanced_trainings_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 class AdvancedTrainingsController < PersonRelationsController
-  self.permitted_attrs = [:description, :year_from, :year_to, :person_id]
+  self.permitted_attrs = %i[description year_from year_to person_id]
 end

app/controllers/application_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 class ApplicationController < ActionController::API
   before_action :authorize
 

app/controllers/authentication_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'ldap_tools'
 
 class AuthenticationController < ApplicationController

app/controllers/crud_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 # A generic controller to display, create, update and destroy entries of a certain model class.
 class CrudController < ListController
   class_attribute :permitted_attrs, :nested_models
@@ -80,7 +78,7 @@ def model_params
     attrs = map_relationships(attrs)
     AttributeDeserializer.new(attrs, nested_models: nested_models).run
   end
-  
+
   def map_relationships(attrs)
     relationships = params[:data][:relationships]
 

app/controllers/dry_crud/searchable.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 # The search functionality for the index table.
 # Define an array of searchable string columns in your subclassing
 # controllers using the class attribute +search_columns+.

app/controllers/educations_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 class EducationsController < PersonRelationsController
-  self.permitted_attrs = [:location, :title, :year_from, :year_to, :person_id]
+  self.permitted_attrs = %i[location title year_from year_to person_id]
 end

app/controllers/expertise_categories_controller.rb

@@ -1,9 +1,7 @@
-# encoding: utf-8
-
 class ExpertiseCategoriesController < CrudController
-  self.permitted_attrs = [:name, :discipline]
+  self.permitted_attrs = %i[name discipline]
 
-  self.nested_models = [:expertise_topic]
+  self.nested_models = %i[expertise_topic]
 
   def fetch_entries
     raise unless params[:discipline]

app/controllers/expertise_topic_skill_values_controller.rb

@@ -1,10 +1,8 @@
-# encoding: utf-8
-
 class ExpertiseTopicSkillValuesController < CrudController
-  self.permitted_attrs = [:years_of_experience, :number_of_projects, :last_use, 
-                          :skill_level, :comment, :expertise_topic_id, :person_id]
+  self.permitted_attrs = %i[years_of_experience number_of_projects last_use
+                          skill_level comment expertise_topic_id person_id]
 
-  def create(options= {})
+  def create(options = {})
     person_id = params[:data][:relationships][:person][:data][:id]
     if person_id
       raise 'not yet implemented' if Person.find(person_id).origin_person_id

app/controllers/expertise_topics_controller.rb

@@ -1,9 +1,7 @@
-# encoding: utf-8
-
 class ExpertiseTopicsController < CrudController
-  self.permitted_attrs = [:name, :user_topic, :expertise_category_id]
+  self.permitted_attrs = %i[name user_topic expertise_category_id]
 
-  self.nested_models = [:expertise_topic_skill_values]
+  self.nested_models = %i[expertise_topic_skill_values]
 
   def fetch_entries
     raise unless params[:category_id]

app/controllers/list_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 # A generic controller to display entries of a certain model class.
 class ListController < ApplicationController
   delegate :model_class, :model_identifier, :model_serializer, :list_serializer,

app/controllers/people_controller.rb

@@ -1,14 +1,12 @@
-# encoding: utf-8
-
 class PeopleController < CrudController
-  self.permitted_attrs = [:birthdate, :picture, :language, :location,
-                          :martial_status, :updated_by, :name, :origin, :role, :title,
-                          :competences, :status_id, :variation_name, :company]
+  self.permitted_attrs = %i[birthdate picture language location
+                          martial_status updated_by name origin role title
+                          competences status_id variation_name company]
 
-  self.nested_models = [:advanced_trainings, :activities, :projects,
-                        :educations]
+  self.nested_models = %i[advanced_trainings activities projects
+                        educations]
 
-  skip_before_action :authorize, only: [:picture]
+  skip_before_action :authorize, only: :picture
 
   def index
     people = fetch_entries
@@ -22,7 +20,7 @@ def show
   end
 
   def update_picture
-    person.update_attributes(picture: params[:picture])
+    person.update(picture: params[:picture])
     render json: { data: { picture_path: person_picture_path(params[:person_id]) } }
   end
 
@@ -102,15 +100,15 @@ def content_disposition_filename_ascii(filename)
     'filename="' +
       percent_escape(
         I18n.transliterate(filename),
-        /[^ A-Za-z0-9!#$+.^_`|~-]/
+        /[^ A-Za-z0-9!#{$+}.^_`|~-]/
       ) + '"'
   end
 
   def content_disposition_filename_utf8(filename)
     "filename*=UTF-8''" +
       percent_escape(
         filename,
-        /[^A-Za-z0-9!#$&+.^_`|~-]/
+        /[^A-Za-z0-9!#{$&}+.^_`|~-]/
       )
   end
 

app/controllers/person_relations_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 class PersonRelationsController < CrudController
   def person_id
     params['data']['relationships']['person']['data']['id']

app/controllers/person_variations_controller.rb

@@ -1,7 +1,5 @@
-# encoding: utf-8
-
 class PersonVariationsController < CrudController
-  self.permitted_attrs = PeopleController.permitted_attrs + [:variation_name, :person_id]
+  self.permitted_attrs = PeopleController.permitted_attrs + %i[variation_name person_id]
 
   self.nested_models = PeopleController.nested_models
 
@@ -17,7 +15,7 @@ def create
     else
       render json: variation.errors.details, status: :unprocessable_entity
     end
-  rescue => e
+  rescue StandardError => e
     render json: e.message, status: :unprocessable_entity
   end
 

app/controllers/projects_controller.rb

@@ -1,6 +1,4 @@
-# encoding: utf-8
-
 class ProjectsController < PersonRelationsController
-  self.permitted_attrs = [:description, :title, :role, :technology, 
-                          :year_to, :year_from, :person_id]
+  self.permitted_attrs = %i[description title role technology
+                          year_to year_from person_id]
 end

app/controllers/static_assets_controller.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 class StaticAssetsController < ActionController::Base
 
   protect_from_forgery with: :null_session

app/jobs/application_job.rb

@@ -1,4 +1,2 @@
-# encoding: utf-8
-
 class ApplicationJob < ActiveJob::Base
 end

app/mailers/application_mailer.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 class ApplicationMailer < ActionMailer::Base
   default from: '[email protected]'
   layout 'mailer'

app/models/activity.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 # == Schema Information
 #
 # Table name: activities
@@ -19,7 +17,7 @@ class Activity < ApplicationRecord
   belongs_to :person, touch: true
 
   validates :year_from, :person_id, :role, presence: true
-  validates :year_from, :year_to, length: {is: 4}, allow_blank: true
+  validates :year_from, :year_to, length: { is: 4 }, allow_blank: true
   validates :description, length: { maximum: 5000 }
   validates :role, length: { maximum: 500 }
   validate :year_from_before_year_to

app/models/advanced_training.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 # == Schema Information
 #
 # Table name: advanced_trainings
@@ -18,7 +16,7 @@ class AdvancedTraining < ApplicationRecord
   belongs_to :person, touch: true
 
   validates :year_from, :person_id, :description, presence: true
-  validates :year_from, :year_to, length: {is: 4}, allow_blank: true
+  validates :year_from, :year_to, length: { is: 4 }, allow_blank: true
   validates :description, length: { maximum: 5000 }
   validate :year_from_before_year_to
 

app/models/application_record.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 

app/models/education.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+
 # == Schema Information
 #
 # Table name: educations
@@ -17,7 +17,7 @@ class Education < ApplicationRecord
   belongs_to :person, touch: true
 
   validates :year_from, :person_id, :title, :location, presence: true
-  validates :year_from, :year_to, length: {is: 4}, allow_blank: true
+  validates :year_from, :year_to, length: { is: 4 }, allow_blank: true
   validates :location, :title, length: { maximum: 500 }
   validate :year_from_before_year_to
 

app/models/expertise_category.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+
 #
 # == Schema Information
 #
@@ -15,12 +15,12 @@ class ExpertiseCategory < ApplicationRecord
   enum discipline: [:development, :system_engineering]
 
   validates :discipline, presence: true
-  validates :name, presence: true, 
-                   uniqueness: { scope: :discipline }, 
+  validates :name, presence: true,
+                   uniqueness: { scope: :discipline },
                    length: { maximum: 100 }
 
-  scope :list, -> (discipline = nil) do 
-    where(discipline: discipline )
+  scope :list, ->(discipline = nil) do
+    where(discipline: discipline)
   end
 
 end

app/models/expertise_topic.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+
 #
 # == Schema Information
 #
@@ -14,14 +14,14 @@ class ExpertiseTopic < ApplicationRecord
   belongs_to :expertise_category
   has_many :expertise_topic_skill_values, dependent: :destroy
 
-  validates :name, presence: true, 
-                   length: { maximum: 100 }, 
+  validates :name, presence: true,
+                   length: { maximum: 100 },
                    uniqueness: { scope: :expertise_category }
 
-  scope :list, -> (category_id= nil) do 
+  scope :list, ->(category_id = nil) do
     includes(:expertise_category, :expertise_topic_skill_values).
-    where(expertise_categories: { id: category_id } ).
-    where(user_topic: false)
+      where(expertise_categories: { id: category_id }).
+      where(user_topic: false)
   end
 
 end