fix tests after changing category of skill

spec/controllers/api/skills_controller_spec.rb

@@ -4,10 +4,6 @@
   describe 'SkillsController as admin' do
     before { load_pictures }
 
-    before(:each) do
-      allow_any_instance_of(SkillsController).to receive(:admin_flag?).and_return(true)
-    end
-
     let(:bob) { people(:bob) }
 
     describe 'GET index' do
@@ -57,13 +53,13 @@
         get :index, params: { category: parent_category.id }
 
         skills = json['data']
-        expect(skills.count).to eq(3)
+        expect(skills.count).to eq(4)
         cunit_attrs = skills.first['attributes']
-        junit_attrs = skills.second['attributes']
-        rails_attrs = skills.third['attributes']
+        ember_attrs = skills.second['attributes']
+        junit_attrs = skills.third['attributes']
         expect(cunit_attrs['title']).to eq ('cunit')
+        expect(ember_attrs['title']).to eq ('ember')
         expect(junit_attrs['title']).to eq ('JUnit')
-        expect(rails_attrs['title']).to eq ('Rails')
       end
 
       it 'returns skills with parent category software-engineering and defaultSet true' do
@@ -104,13 +100,10 @@
       end
     end
   end
+
   describe 'SkillsController as normal user' do
     before { load_pictures }
 
-    before(:each) do
-      allow_any_instance_of(SkillsController).to receive(:admin_flag?).and_return(false)
-    end
-
     let(:bob) { people(:bob) }
 
     describe 'GET index' do
@@ -160,13 +153,13 @@
         get :index, params: { category: parent_category.id }
 
         skills = json['data']
-        expect(skills.count).to eq(3)
+        expect(skills.count).to eq(4)
         cunit_attrs = skills.first['attributes']
-        junit_attrs = skills.second['attributes']
-        rails_attrs = skills.third['attributes']
+        ember_attrs = skills.second['attributes']
+        junit_attrs = skills.third['attributes']
         expect(cunit_attrs['title']).to eq ('cunit')
+        expect(ember_attrs['title']).to eq ('ember')
         expect(junit_attrs['title']).to eq ('JUnit')
-        expect(rails_attrs['title']).to eq ('Rails')
       end
 
       it 'returns skills with parent category software-engineering and defaultSet true' do

spec/domain/skills_filter_spec.rb

@@ -18,10 +18,11 @@
       filter = SkillsFilter.new(Skill.all, 458108788, nil, nil)
       filteredSkills = filter.scope
 
-      expect(filteredSkills.count).to eq(3)
+      expect(filteredSkills.count).to eq(4)
       expect(filteredSkills[0].title).to eq('Rails')
       expect(filteredSkills[1].title).to eq('JUnit')
       expect(filteredSkills[2].title).to eq('cunit')
+      expect(filteredSkills[3].title).to eq('ember')
     end
 
     it 'filters skills by title' do

spec/exporters/csv/skillset_spec.rb

@@ -5,7 +5,7 @@
     it 'exports' do
       csv = Csv::Skillset.new(Skill.all).export
       csv = csv.split("\n")
-      expect(csv.length).to eq(5)
+      expect(csv.length).to eq(6)
       expect(csv.first.split(",").length).to eq(7)
       rails = csv.select { |s| s.include?('Rails') && s.include?('5') }.first
       expect(rails).not_to eq (nil)