-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/601 people dropdown #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcinay055679
force-pushed
the
feature/601-select-peopole
branch
from
February 20, 2024 14:40
2d0c197
to
27e5569
Compare
kcinay055679
force-pushed
the
feature/601-select-peopole
branch
from
February 22, 2024 08:39
caa9b7e
to
b2c727e
Compare
Robin481
previously requested changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good!
Some nitpicking and then we are good 🚀
kcinay055679
force-pushed
the
feature/601-select-peopole
branch
from
February 23, 2024 09:17
4adf6a8
to
ef1c144
Compare
kcinay055679
force-pushed
the
feature/601-select-peopole
branch
from
February 23, 2024 09:18
ef1c144
to
1df13a7
Compare
Robin481
approved these changes
Feb 23, 2024
kcinay055679
added a commit
that referenced
this pull request
Mar 1, 2024
* add stimulus controller to redirect with 2nd select with normal link to syntax * update people show * rename controller to dropdown_controller.js * create 2nd run proifle * show dropdown as partial and select correct default value * add tests * clean up * fix pipeline * update pry-byebug and specify feature as target for headless test * add husky * fix npm config * fix capybara config * fix pipeline * fix pipeline * add chrome to github action * fix pipeline * fix pipeline * fix pipeline * fix pipeline * fix pipelien * use specific chrome * fix pipelien * fix pipeline * fix pipeline * update gemfile * fix pipeline * fix pipeliebn * fix pipeline * reuse chrome * inshalla * fasdf * clean up * clean up * clean up * fix typo * resolve conversations from PR --------- Co-authored-by: Yanick Minder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.